search

vyznev / soup

Stack Overflow Unofficial Patch
27 stars 6 forks source link

User avatars appear in wrong spot on Microsoft Edge #32

Closed gparyani closed 6 years ago

gparyani commented 6 years ago

In Microsoft Edge, running the latest stable version of SOUP in Tampermonkey, the user avatars appear in the wrong spot, below where they should be:

avatar appears below where it should be

Question where this screenshot was taken

vyznev commented 6 years ago

Thanks. Just to check, do you still see this behavior on SOUP v1.50 (released yesterday)? I don't see anything obvious in the changelog that might've affected this, but it's worth checking before I start chasing false trails. I still haven't actually managed to test this on Edge, but I was hoping I could at least narrow down the list of fixes that could cause it.

vyznev commented 6 years ago

BTW, if you don't mind playing with the source code, you could help me narrow this down. Most of the SOUP source code consists of individual fix entries of the form fixes.someid123 = { ... }. If you want, you could open the SOUP source code in the Tampermonkey dashboard, remove a bunch of those fix entries and see if the problem still persists. (Of course, remember to Ctrl+S and reload the page.) Repeat until it does, then undo the last step and remove something else. Eventually, you should be able to narrow it down to a single fix entry (or possibly two that interact in some weird way).

Then just let me know the ID of the entry. My guess would be that it's probably one of the CSS-only fixes near the top of the code, since this looks like a CSS problem, but I can't be sure.

Ps. Two fixes that you might try disabling first are fixes.mse108046 and fixes.mse84296. I'm not sure why either of those should cause the problem shown in your screenshot (since they deal with mouse cursors and Unicode bidirectional text, respectively), but they're the only fixes I can find with custom CSS that applies to the avatars in user cards. And the BiDi fix at least has had some weird browser compatibility issues reported before, although so far only with Safari.

gparyani commented 6 years ago

This does still happen on v1.50.0. I'll check which fix(es) trigger it and post another reply in a while.

gparyani commented 6 years ago

And it looks like mse84296 is causing the issue. I commented that out and the avatars show normally.

vyznev commented 6 years ago

Thanks again! There's actually no real reason for the mse84296 CSS rule to apply to the avatars, so if that's the only issue, excluding them ought to be doable. That said, while you're at it, could you please also check if this Safari bug (or something similar) occurs on Edge with SOUP (and the mse84296 fix) enabled?

vyznev commented 6 years ago

Can you try installing SOUP v1.51.4 from the development branch and see if this issue persists? If it does, I can add a more explicit rule to exclude avatars from the bidi style, but I figured I'd first see if just removing the fallbacks would help.

gparyani commented 6 years ago

No, the Safari bug does not occur on Edge with the current version of the patch.

The development branch correctly fixes the avatar bug in Edge.

vyznev commented 6 years ago

Thanks! I'll mark this as resolved. The updated CSS without the fallbacks will be included in the next stable SOUP release (v1.52).