search

vyznev / soup

Stack Overflow Unofficial Patch
27 stars 6 forks source link

This breaks the new activity icon. #44

Closed Peilonrayz closed 5 years ago

Peilonrayz commented 5 years ago

This breaks the new activity style. It should look like:

enter image description here

However it looks like this:

enter image description here

Removing the following style fixes this for me.

.question-summary .question-hyperlink {
  display: block;
}
vyznev commented 5 years ago

Huh... I've never seen that icon, and I can't seem to figure out how to make it appear. Any idea how I might be able to reproduce that?

Obviously, I can just disable the problematic fix, and I'll do that if I can't fix it any other way. But I'd prefer to make it work correctly with the icon if I can.

Peilonrayz commented 5 years ago

Honestly I don't know how to reproduce it. It seems to appear on my custom filters, it may be when I've looked at the list and a question gets edited, but I'm not sure.

If you:

  1. Make some custom filters,
  2. Save them so they appear on the right hand side of the SE you main at. and
  3. Look at them every now and then.

You should be able to get on to pop up within a day, or at least that worked for me. Best of luck.

vyznev commented 5 years ago

Thanks, managed to repro it. It looks like adding something like the following CSS should fix it:

.question-summary .activity-indicator {
    float: left;
    margin-top: 4px;
}

I'll add that to the development branch right now, and consider making a new stable release in a day or two.

vyznev commented 5 years ago

Fixed in SOUP v1.56.