search

vyznev / soup

Stack Overflow Unofficial Patch
27 stars 6 forks source link

fixes.mso300679 broken due to changes rolled out on 2019-10-03 #47

Open mjpieters opened 5 years ago

mjpieters commented 5 years ago

Today SE rolled out a change titled "Refactor post validation", causing the following error to appear in the console:

TypeError: StackExchange.postValidation.getSidebarPopupOptions is not a function -1:333:47
    <anonymous> https://stackoverflow.com/users/message/create/-1:333
    jQuery 3
    MarkdownEditor https://cdn.sstatic.net/Js/wmd.en.js?v=c7f5081cdae1:2
    e https://cdn.sstatic.net/Js/wmd.en.js?v=c7f5081cdae1:2
    t https://cdn.sstatic.net/Js/wmd.en.js?v=c7f5081cdae1:3
    n https://cdn.sstatic.net/Js/full.en.js?v=1d06422f5fb7:4

This is from fixes.mso300679:

https://github.com/vyznev/soup/blob/0b267e18c52baab4e730d5dfa230eb08e8782f1a/SOUP.user.js#L831

Unfortunately, this breaks the moderator-only 'contact user privately' feature, so I've had to disable S.O.U.P. altogether. This also breaks the WMD editor elsehwere, just not as completely; the editor is left in an unfinished state without buttons.

vyznev commented 5 years ago

Thanks for the report. I've pushed out a point version (1.56.2 / 1.57.8) that just disables this fix for now. I'll look into making it work with the new post validation code later, possibly this weekend.

double-beep commented 4 years ago

As a temporary workaround, you can use:

var options = {"position":{"my":"left top","at":"right center"},"css":{"max-width":300,"min-width":300},"closeOthers":false};