search

vz-risk / Verum

Implementation of Context-Graph algorithms for graph enrichment and querying.
Apache License 2.0
24 stars 7 forks source link

Time (start_time) is incredibly poorly handled in plugins #26

Closed gdbassett closed 9 years ago

gdbassett commented 9 years ago

All enrichment plugins take a "start_time" input, however it is poorly defined and inconsistently used:

Many plugins drop it w/o using it.

Many plugins redefine the time to 'now', ignoring "start_time"

Many plugins then, instead of using 'now', use a new check on the time at node creation time.

Expected behavior:

  1. start_time converted to string in correct format (whether it comes in as a string or a datetime)
  2. Use start_time for all times where it makes sense.
  3. Where it doesn't make sense, document why
gdbassett commented 9 years ago

Fixed in commit [gabe 6c159e8].