search

vzctl / RationalReads

5 stars 1 forks source link

New lines destroyed or not displayed for comments. #8

Closed Amit-P-Amin closed 9 years ago

Amit-P-Amin commented 9 years ago

I just posted a couple more reviews and on each of them all formatting was lost after the post. This condensed several paragraphs of comments into a single unreadable block of text. I have not had that problem before so I am not sure what is causing, but thought I should point out.

nevinera commented 9 years ago

It looks like your comment_show template just puts the comments in a div - raw text in html ignores whitespace (if you run gsub(/\s+/, ' ') on it, you render the same result). The easy answer is to style a pre tag so it doesn't look awful, or to split on newlines and wrap individual paragraphs in p tags.

Would you prefer markdown, like reddit? I've added that to a few of my projects, it's pretty easy to manage with redcarpet.

Amit-P-Amin commented 9 years ago

Awesome! That was easy to fix! Do you think markdown would be helpful? I can't imagine it getting used that often.

nevinera commented 9 years ago

Yeah, probably not that important, since it's not really a discussion site. On Mar 31, 2015 2:56 PM, "Amit Amin" notifications@github.com wrote:

Closed #8 https://github.com/Amit-P-Amin/RationalReads/issues/8.

— Reply to this email directly or view it on GitHub https://github.com/Amit-P-Amin/RationalReads/issues/8#event-269895707.