search

vzdc / vzdcwebsite

https://www.vzdc.org
3 stars 4 forks source link

Feature/visiting roster #213

Open fixterjake opened 3 years ago

fixterjake commented 3 years ago

First pass at this. Due to the nature of making api calls that cannot easily be undone, wanted to get approval before testing. @victor46 if you approve please don't merge so that I can check out the individual branch before merging

fixterjake commented 3 years ago

Does this pull from VATUSA for the visiting roster? Or do we push from VATUSA our visiting roster? Also does it remove them once we do on our end if we are pushing? Where is the point of truth?

So to get them form vatusa, I changed the roster update command and added /both to the end of the url, which gets the home and visiting roster. And as for removal I send a request to remove them from the visiting roster on removal, or if they are changed from a visitor on the roster

victor46 commented 3 years ago

Final question, we ARE using our website as the point of truth correct? So any changes we make on our site will push to VATUSA's roster correct?

fixterjake commented 3 years ago

Final question, we ARE using our website as the point of truth correct? So any changes we make on our site will push to VATUSA's roster correct?

The only way they end up on the visiting roster is by you accepting them, then we pull their details with the roster to update if anything changes

victor46 commented 3 years ago

I don't think we are talking about the same thing, let me know when we can discuss with.s

victor46 commented 3 years ago

Can't approve this pull, has conflicts.