vzhd1701 / csv2notion

Import/Merge CSV files into Notion database
MIT License
74 stars 10 forks source link

[Bug]: Default Icon argument doesn't like the ⛔ emoji #9

Closed latenitefilms closed 2 years ago

latenitefilms commented 2 years ago

csv2notion version

csv2notion 0.3.0

What OS are you using?

MacOS

OS Version / Linux distribution

macOS 12.4

Bug description

csv2notion doesn't seem to like the ⛔ emoji?

Log excerpt

./csv2notion --token "XXX" --default-icon "⛔"️ --verbose xxx.csv     
File not found: ⛔️
vzhd1701 commented 2 years ago

Hm, strange. It works without quotes though.

latenitefilms commented 2 years ago

Umm, I couldn’t get it to work without quotes, however I’m triggering it through another app not directly from Terminal. Will do some more digging. Thanks for fast reply!

vzhd1701 commented 2 years ago

From some sources the emoji comes encoded in 6 bytes, while other sources encode it in 3. Will redo emoji detection function now.

vzhd1701 commented 2 years ago

Seems like some sources add variation selector to the emoji https://www.emojiall.com/en/emoji/%EF%B8%8F

Should be fixed now. Check out the new version.

latenitefilms commented 2 years ago

Fixed - thanks heaps @vzhd1701!