[Bug]: App. overlay when app. is running in background is shown obove front apps

dv8472 commented 2 years ago

GridPlayer version

GridPlayer-0.3.0-x86_64.AppImage

What OS are you using?

Linux

OS Version / Linux distribution

Arch

What distribution channel are you using? [LINUX ONLY]

AppImage

Bug description

I believe this is the default, which I have:

The issue:

In provided example screenshot:

Gridplayer running in background, left.
browser (or any other app.) is running in front, above the Gridplayer. If I move the mouse cursor like accidentally over the Gridplayer, the overlay of that particular frame is shown. Now that would be quite alright, if the Gridplayer wouldn't draw the overlay above on the top of Gridplayer's another running app., browser in this example case.

Log excerpt

No response

vzhd1701 commented 2 years ago

This should be fixed. Please check out the new version.

dv8472 commented 2 years ago

Unfortunatelly ain't fixed. It even changed behaviour. While before I saw only those two strips per frame I shown on my previous screenshot, now:

when I move the mouse over the playing frames (app. is in back or front, doesn't matter), the whole frame goes gray or black (depends whether the "opaque overlay" setting is on or off): Not sure, if this is related to changes you made in regard to this bug, or whether it's related to some other changes you've made in the new version.
the originally reported issue is still there, also including the previously mentioned:

vzhd1701 commented 2 years ago

What shell are you using?

dv8472 commented 2 years ago

shell? BASH

vzhd1701 commented 2 years ago

I mean Gnome, KDE, xfce?

dv8472 commented 2 years ago

only Openbox. The others which you mentioned, are also installed, but mostly as library dependencies for other apps which require them, therefore.

vzhd1701 commented 2 years ago

Hotfix version released. Please check it out and tell how it works for you.

I fixed transparency mask for opaque overlay. You don't have a compositor?

I have also added a workaround setting that should prevent this issue from happening. Tested on LXQt that uses Openbox.

Clipboard Image (2)

dv8472 commented 2 years ago

I haven't needed a compositor much. Now, with 0.4.1 when I open my playlist, I get only this: And it doesn't end by playing the streams. It eventually ends up because of the timeout: and:

Installing and starting a compositor Xcompmgr doesn't help here either.

Wow this is getting complicated.

dv8472 commented 2 years ago

However, when installed via PIP, it works differently, bit better. More details will follow, when I test it thoroughly.

dv8472 commented 2 years ago

via PIP, installed using pip install -U gridplayer.

using compositor changes very little.
without compositor running:
with compositor running:
that new function "Fake overlay invisibility" helps a little: -- when not enabled, it will show the straps as reported before. -- when enabled, the behaviour changes: --- if I open or refresh/reload the playlist, it can, but not necessarily always show the straps above the front app. --- but!! if I switch between the apps, either with mouse, or alt+tab, and get the gridplayer again to the background, it starts working properly.

vzhd1701 commented 2 years ago

Now, with 0.4.1 when I open my playlist, I get only this

Did it work normal with 0.4.0? Do you use AppImage?

dv8472 commented 2 years ago

Now, with 0.4.1 when I open my playlist, I get only this

Did it work normal with 0.4.0? Do you use AppImage?

Using 0.4.0 AppImage, it worked. As of 0.4.1 AppImage, that reported is the only result. With 0.4.1 via PIP it works, however.

vzhd1701 commented 2 years ago

Seems like an upstream build tool glitch ruined the 0.4.1 AppImage. I have rebuilt the AppImage, it should work now.

vzhd1701 commented 2 years ago

using compositor changes very little.

With compositor you won't need "opaque overlay" fix, that's it. The issue with overlay popping above other windows is not related to compositor.

Overlay is a floating window, that's why it is so sensitive to OS window manager. This is the only way to draw overlay over VLC video surface. I think I'll have to move from libVLC to MPV in the future and hopefully these problems will go away since MPV can render picture in more manageable ways and I won't have to hack in any floating windows.

I've made another attempt on fixing this issue. Please check out version 0.4.2.

dv8472 commented 2 years ago

Seems like an upstream build tool glitch ruined the 0.4.1 AppImage. I have rebuilt the AppImage, it should work now.

Confirmed, now it works. Overlay behaviour just like with the PIP.

using compositor changes very little.

With compositor you won't need "opaque overlay" fix, that's it. The issue with overlay popping above other windows is not related to compositor.

Overlay is a floating window, that's why it is so sensitive to OS window manager. This is the only way to draw overlay over VLC video surface. I think I'll have to move from libVLC to MPV in the future and hopefully these problems will go away since MPV can render picture in more manageable ways and I won't have to hack in any floating windows.

I've made another attempt on fixing this issue. Please check out version 0.4.2.

Thanks for the explanation. I don't see any difference between 0.4.1 and 0.4.2. Your attempt since 0.4.1 is already some progress, at least for me, knowing, that alt+tab/mouse click (going to gridplayer and back to the other app.) is a partial workaround, which helps too. I would say, you can suspend your effort on this for the moment, until you find your time to go for the MPV change you're describing. Thanks a lot anyway, for your effort.

vzhd1701 / gridplayer