search

vzhn / netty-http-authenticator

Basic and digest HTTP authentication for Netty
MIT License
12 stars 9 forks source link

Integration with Spring Webflux #1

Open PyvesB opened 4 years ago

PyvesB commented 4 years ago

Hello there!

Thanks for making this project. I've been trying to perform Digest Auth with Spring's Webclient and plugging this library in was suggested as a potential way to achieve this. See https://github.com/spring-projects/spring-framework/issues/24425 for some more context.

The library currently expects aggregated FullHttpRequest and FullHttpResponse objects, which, if I'm not mistaken, wouldn't work when using Flux reactive types and chunked encoding. Digest auth doesn't actually involve any response/request bodies, could the library be modified to use HttpRequest and HttpResponse instead, lifting some of its current limitations? Or is there something else that we're missing?

Thanks in advance!

vzhn commented 4 years ago

Hello! I've just noticed this Issue. Github did not sent me notification for some reason.

It hard to answer right now. If it's still actual i'll see on weekend.

vzhn commented 4 years ago

Yes, this is possible. Work in progress: https://github.com/vzhn/netty-http-authenticator/blob/massive_refactoring/src/test/java/me/vzhilin/demo/webflux/WebFluxDemo.java

I have no spring experience. Any advice would be appreciated.