search

vzhou842 / profanity-check

A fast, robust Python library to check for offensive language in strings.
https://pypi.org/project/profanity-check
MIT License
612 stars 113 forks source link

Retrained model with scikit-learn 0.23.2 #27

Open owenjones opened 3 years ago

owenjones commented 3 years ago

Update on koti's PR to retrain the model with scikit-learn 0.23.2 to hide warnings (Trying to unpickle <...> from version 0.23.1 when using version 0.23.2. This might lead to breaking code or invalid results. Use at your own risk.)

menkotoglou commented 3 years ago

Many thanks for your contribution @owenjones. Is it possible for you to submit a pull request on Dimitry's fork as well? We consider releasing it as a Python package.

owenjones commented 3 years ago

Sure - have just submitted a pull request there

menkotoglou commented 3 years ago

Thank you very much.

mjam03 commented 3 years ago

Hey, just another voice saying that would be great if this PR was merged into master (and version released for pip). I think this repo is a nice simple solution and would be a shame to see it left behind /deprecated as sklearn versions progress.

Maybe a bit of a simple/silly question, but is there any way to persist sklearn models s.t. they don't need retrained with a newer version of sklearn each time? As in, can you:

I appreciate it's not really a qu specific to this repo but was curious.

menkotoglou commented 3 years ago

Hello @mjam03,

The only developer who has permission merge PRs into master is the original author. Since he seems to have dropped this project, @dimitrismistriotis and I decided to maintain this project.

You can find the source code here: https://gitlab.com/dimitrios/alt-profanity-check.

Additionally, we released an alternative version for pip. You can find it here: https://pypi.org/project/alt-profanity-check/.

To answer your question, I don't know (and don't think there is) a way to use a model without installing the version it is trained on.

mjam03 commented 3 years ago

@koti Great news! Thanks v much!

Will drop my local fork of @owenjones branch and instead just standard pip install the 'alt version'.