search

vzhou842 / profanity-check

A fast, robust Python library to check for offensive language in strings.
https://pypi.org/project/profanity-check
MIT License
612 stars 113 forks source link

setup.py sklearn reqt #7

Closed bscully27 closed 4 years ago

bscully27 commented 4 years ago

setup.py has, "scikit-learn==0.20.2"

at least change to greater than or equal: scikit-learn>=0.20.2

vshestopalov commented 4 years ago

That's a good point, otherwise it's hard to use in env with another ML stuff.

vzhou842 commented 4 years ago

That's fair @bscully27, would love a PR if you want to tackle it

vchulski commented 4 years ago

@vzhou842 To use scikit-learn of higher versions without warnings it's needed to re-train models and create new model and vectorizer dumps.

vzhou842 commented 4 years ago

done #8