search

w-a-r-m-inventory-system / Food-Pantry-Inventory

New Inventory System for Westerville Area Resource Ministry
MIT License
23 stars 20 forks source link

Github testing and coverage failing. #262

Closed deeppunster closed 4 years ago

deeppunster commented 4 years ago

Describe the bug Github tests are failing to run. Coverage also fails.

To Reproduce Steps to reproduce the behavior:

  1. Submit a PR (e.g. #260)
  2. Observe that the tests fail.
  3. The raw logs show that it is failing because "STATIC_ROOT" is not set.

Expected behavior Expect the tests to run if the PR is properly configured.

Log Entry

2020-08-11T06:21:15.9173139Z   File "/home/runner/work/Food-Pantry-Inventory/Food-Pantry-Inventory/FPIDjango/settings.py", line 202, in <module>
2020-08-11T06:21:15.9173487Z     STATIC_ROOT = STATIC_ROOT
2020-08-11T06:21:15.9173796Z NameError: name 'STATIC_ROOT' is not defined
2020-08-11T06:21:16.6563730Z ##[error]Process completed with exit code 1.

Desktop (please complete the following information):

Additional context

deeppunster commented 4 years ago

Pull request #266 fixed this issue. Thanks to Jeff Allman who identified where the fix was needed.