w-yeehong / pe

0 stars 0 forks source link

Duplicate names are allowed for contacts if the casing is different #1

Open w-yeehong opened 4 years ago

w-yeehong commented 4 years ago

Expected Outcome

Duplicate names should not be allowed as long as they are the same, regardless of whether it is in upper- or lowercase.

Problem

Duplicate names are allowed if they are in different casing.

Steps to Reproduce

  1. Execute add -c n/aaa

  2. Execute add -c n/AAA

  3. It is possible to add contacts with names aaa and AAA image.png

nus-se-bot commented 3 years ago

Team's Response

Intended behaviour. You can also add two contacts of the same name, as long as they have different emails and phone numbers.

Our design philosophy was that we should not arbitrarily restrict what all users can do based on "problems" that may affect few users. It's not unlikely that you have two contacts with the same name in the address book. A user should have the flexibility to be able to add whatever they desire to the address book.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: Hello, thank you for your response.

You mentioned that it is not unlikely that you have two contacts with the same name in the address book. In that case, I still think it is a feature flaw. I understand that the restriction for contacts with duplicate names stems from AB3. However, if your users commonly have contacts with the same names, then there is sufficient reason to change that behavior. Based on your intended users and design philosophy of not restricting the users, I believe the "duplicate names not allowed" behavior should not be enforced in the first place.