search

w-yeehong / pe

0 stars 0 forks source link

MAX_INT triggers invalid command error message instead of invalid index #3

Open w-yeehong opened 4 years ago

w-yeehong commented 4 years ago

Expected Outcome

The error message The person index provided is invalid appears for values that exceed MAX_INT.

Description

The error message Invalid command format! is displayed for values that exceed MAX_INT.

Steps to Reproduce

  1. Execute delete -c 10000000000

  2. The following error message is displayed. image.png

nus-se-bot commented 3 years ago

Team's Response

Inherited from AB3. Rejected as per prof instructions here: https://github.com/nus-cs2103-AY2021S1/forum/issues

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: Hello, thank you for your response.

AB3 does indeed have the same issue. That said, I think you could fix the incorrect error message when adding the -c flag for deletion of contacts. Moreover, I gave an example using delete -c, but the other delete commands such as delete -e face the same issue and those commands are not in AB3. I think that it should not be considered a bug inherited from AB3.