w00kie-n00kie / TheWinchester

6 stars 1 forks source link

WMMQualityDegradationOnRepair possible bug #1

Closed magejosh closed 2 years ago

magejosh commented 2 years ago

Hi, I really love your work here and am wanting to use this one and others from the winchester project in my overhaul project Trapped in Purgatory. In my testing I've found a possible bug with this one. When i craft a t1 stone axe and try to repair it, it turns into a tierless stone axe which cannot take degradation damage and the crafting window breaks. I get a string of exception errors in the console as well. At first i thought it was because i'd set all items to true on the degradationbreaksafter property. But disabled that and it happened anyways. Figured i'd check here to see if anyone else has reported it and it looks like i'm the only one. If you have time to help i'd appreciate it. I'm easier to reach in guppycur's discord than on here but i'll check back as well.

Here's a copy of the first one in the string that repeats. It goes through all the window groups eventually if i let it keep going. then repeats the cycle.

2022-08-03T23:54:38 772.592 ERR [XUi] Error while updating window group 'crafting': 2022-08-03T23:54:38 772.610 EXC Index was outside the bounds of the array. at (wrapper dynamic-method) QualityInfo.DMD(int) at QualityInfo.GetQualityColor (System.Int32 _quality) [0x00000] in <6a01347f98174dbdb41cb4a4eedf5af7>:0 at XUiC_ItemStack.GetBindingValue (System.String& _value, System.String _bindingName) [0x00393] in <6a01347f98174dbdb41cb4a4eedf5af7>:0 at BindingItemStandard.GetValue (System.Boolean _forceAll) [0x00013] in <6a01347f98174dbdb41cb4a4eedf5af7>:0 at BindingInfo.RefreshValue (System.Boolean _forceAll) [0x0001a] in <6a01347f98174dbdb41cb4a4eedf5af7>:0 at XUiController.RefreshBindings (System.Boolean _forceAll) [0x00010] in <6a01347f98174dbdb41cb4a4eedf5af7>:0 at XUiC_ItemStack.set_QuestLock (System.Boolean value) [0x0000d] in <6a01347f98174dbdb41cb4a4eedf5af7>:0 at XUiC_ItemStack.set_ItemStack (ItemStack value) [0x000f1] in <6a01347f98174dbdb41cb4a4eedf5af7>:0 at XUiC_ItemStackGrid.SetStacks (ItemStack[] stackList) [0x0004e] in <6a01347f98174dbdb41cb4a4eedf5af7>:0 at XUiC_Toolbelt.PlayerInventory_OnToolbeltItemsChanged () [0x00007] in <6a01347f98174dbdb41cb4a4eedf5af7>:0 at (wrapper delegate-invoke) .invoke_void() at XUiM_PlayerInventory.onToolbeltItemsChanged () [0x00008] in <6a01347f98174dbdb41cb4a4eedf5af7>:0 at (wrapper delegate-invoke) .invoke_void() at Inventory.onInventoryChanged () [0x00008] in <6a01347f98174dbdb41cb4a4eedf5af7>:0 at Inventory.CallOnToolbeltChangedInternal () [0x00000] in <6a01347f98174dbdb41cb4a4eedf5af7>:0 at Inventory.syncHeldItem () [0x001b3] in <6a01347f98174dbdb41cb4a4eedf5af7>:0 at Inventory.setHoldingItemTransfrom (UnityEngine.Transform _t) [0x00102] in <6a01347f98174dbdb41cb4a4eedf5af7>:0 at Inventory.updateHoldingItem () [0x00197] in <6a01347f98174dbdb41cb4a4eedf5af7>:0 at Inventory.SetItem (System.Int32 _idx, ItemValue _itemValue, System.Int32 _count, System.Boolean _notifyListeners) [0x0010b] in <6a01347f98174dbdb41cb4a4eedf5af7>:0 at Inventory.ReturnItem (ItemStack _itemStack) [0x000ac] in <6a01347f98174dbdb41cb4a4eedf5af7>:0 at XUiM_PlayerInventory.AddItem (ItemStack _itemStack, System.Boolean playCollectSound) [0x00300] in <6a01347f98174dbdb41cb4a4eedf5af7>:0 at XUiM_PlayerInventory.AddItemNoPartial (ItemStack _itemStack, System.Boolean playCollectSound) [0x0001e] in <6a01347f98174dbdb41cb4a4eedf5af7>:0 at WMMQualityDegradationOnRepair+PatchXUiC_RecipeStackoutputStack.Prefix (XUiC_RecipeStack instance, System.Boolean& result, Recipe& recipe, ItemValue& originalItem, ItemValue& outputItemValue, System.Int32& outputQuality, System.Int32& startingEntityId, System.Int32& amountToRepair, System.Boolean& playSound, System.Boolean& isInventoryFull) [0x0054f] in <65bb3164544844e1a4fe7cfbf46fc8af>:0 at (wrapper dynamic-method) XUiC_RecipeStack.DMD(XUiC_RecipeStack) at XUiC_RecipeStack.Update (System.Single _dt) [0x00334] in <6a01347f98174dbdb41cb4a4eedf5af7>:0 at XUiController.Update (System.Single _dt) [0x0004f] in <6a01347f98174dbdb41cb4a4eedf5af7>:0 at XUiController.Update (System.Single _dt) [0x0004f] in <6a01347f98174dbdb41cb4a4eedf5af7>:0 at XUiC_CraftingQueue.Update (System.Single _dt) [0x00000] in <6a01347f98174dbdb41cb4a4eedf5af7>:0 at XUiController.Update (System.Single _dt) [0x0004f] in <6a01347f98174dbdb41cb4a4eedf5af7>:0 at XUiController.Update (System.Single _dt) [0x0004f] in <6a01347f98174dbdb41cb4a4eedf5af7>:0 at XUi.OnUpdateDeltaTime (System.Single updateDeltaTime) [0x00131] in <6a01347f98174dbdb41cb4a4eedf5af7>:0 UnityEngine.StackTraceUtility:ExtractStringFromException(Object) Log:Exception(Exception) XUi:OnUpdateDeltaTime(Single) XUiUpdater:Update() XUiUpdateHelper:LateUpdate()

magejosh commented 2 years ago

Can confirm this was a conflict with another mod causing this aberrant behavior. The mod in question is Enhanced Craft and Repair. Thank You w00kie-n00kie for your assistance in tracking this down!