qBittorrent ignores maximum number of connections per torrent

[GoogleCodeExporter]

The maximum number of connections per torrent is set to 3. But I see this:

https://cloud.githubusercontent.com/assets/9303235/8266563/3c7953de-1756-11e5-99
b7-3c7e9d61141f.png

Win7 x64, qBittorrent v3.2.0, libtorrent 1.0.5

Original issue reported on code.google.com by xtem...@gmail.com on 20 Jun 2015 at 3:45

[GoogleCodeExporter]

I cannot reproduce this. Could you try to reproduce it in libtorrent's 
client_test to make sure it's not a qbittorrent bug?

Original comment by arvid.no...@gmail.com on 20 Jun 2015 at 5:59

[GoogleCodeExporter]

Nor can me. But here (https://github.com/qbittorrent/qBittorrent/issues/3261) I 
was referred to this page to report the bug.

Sometimes I see that the number of peers exceeds the maximum number of 
connections per torrent set in the parameters. I don't know how to reproduce 
this; I just can make the screenshots to prove it. I heard the same complaints 
in #qbittorrent on freenode.org.

Original comment by xtem...@gmail.com on 20 Jun 2015 at 6:45

[GoogleCodeExporter]

Is there a way to run the program in debug mode to obtain logs that I can 
attach?

Original comment by xtem...@gmail.com on 20 Jun 2015 at 6:48

[GoogleCodeExporter]

@arvid I can provide him with a build with "logging=verbose" or any other 
option enabled if you think it can help. Please specify the build options you 
want me to enable.

Original comment by hammered...@gmail.com on 20 Jun 2015 at 6:54

[GoogleCodeExporter]

I don't think there's a lot ofdebug logging for this. I'll add some.

Original comment by arvid.no...@gmail.com on 20 Jun 2015 at 8:59

[GoogleCodeExporter]

ok. head of RC_1_0 has some logging now

Original comment by arvid.no...@gmail.com on 20 Jun 2015 at 9:52

[GoogleCodeExporter]

Ok, how do I create logs and reproduce the problem? It looks like a heisenbug, 
so all I can is to run the program and wait till the peer list exceeds all the 
limits of imagination. It doesn't happen all the time, only once or twice a day.

Original comment by xtem...@gmail.com on 21 Jun 2015 at 8:08

[GoogleCodeExporter]

I think the best bet is probably for hammered to make a debug/logging build 
using the latest RC_1_0 and hand it to you. It occurs to me that I should 
probably add a little bit more logging to try to narrow this down further. I'll 
leave another note when I'm done

Original comment by arvid.no...@gmail.com on 21 Jun 2015 at 9:16

[GoogleCodeExporter]

Ok, i've added some more logging now. Here's the current repo (it's in github 
now):

https://github.com/arvidn/libtorrent/tree/RC_1_0

Original comment by arvid.no...@gmail.com on 22 Jun 2015 at 5:40

[GoogleCodeExporter]

Ok, I forgot to subscribe here.
I'll provide a build the weekend. I don't think I can earlier.
@xtem If you know how to compile here is a complete guide on how the official 
windows builds are done. You can adjuct for compiling from libtorrent git.
Link: 
https://github.com/qbittorrent/qBittorrent/wiki/Compiling-with-MSVC-2008%28stati
c-linkage%29

(okay now I use msvc2013, but the rest is the same)

Original comment by hammered...@gmail.com on 22 Jun 2015 at 11:53

[GoogleCodeExporter]

Compilation requires great efforts. =( If I could easily compile qBittorrent, I 
would have added simple logging to watch peer list.

Having looked through the code I suspect a memory leakage. I also might know 
the way to repeat the problem - after I tried to change maximum number of 
connections per torrent from 3 to 2, from 2 to 4, again 3 and saw again the 
same thing - the number of peers exceeded the limitation. It looks like 
constant changing of settings makes the program behaves crazy. =)

Original comment by xtem...@gmail.com on 22 Jun 2015 at 7:35