w0lfschild / Flashlight

:mag_right: Enhance Spotlight with plugins on macOS
https://www.macenhance.com/flashlight
Other
1.13k stars 56 forks source link

Some plugins can't work on macOS 10.13 #36

Closed limitLiu closed 6 years ago

limitLiu commented 7 years ago

All plugins are ok on macOS 10.12.6, but on macOS 10.13, some plugins can work, others can't work.

chenghuzi commented 7 years ago

It seems that almost all plugins can not work.

imYerik commented 7 years ago

It seems that almost all plugins can not work. sad :(

fuorviatos commented 7 years ago

Sadly, almost all of them do not work and the dev of flashlight stated openly he's not gonna work on fixing them.

Sir-Cumference commented 7 years ago

@fuorviatos Where did w0lfschild say that?

czjxy881 commented 6 years ago

+1

mapping77 commented 6 years ago

Well, the same problem, it seems all plugins don't work.

technolingo commented 6 years ago

This is the problem with open source software. Make it commercial and I would definitely buy it.

mkormendy commented 6 years ago

Yeah I'd pay $20 for it.

w0lfschild commented 6 years ago

Unfortunately I don't really know much about the plugins. This was mainly just meant to fix a few issues that were causing the application to crash.

For me to really do work on this the project would need to separate itself from the original Flashlight servers because right now I can't even push pull request for plugins because the application is pulling from the original server.

I'd gladly take help on this project and keep it free though.

krystofcelba commented 6 years ago

Hi, I have investigated a bit why plugins do not work on macOS 10.13 and seem I got it finally works again.

Feedback welcomed.

Flashlight macOS 10.13

w0lfschild commented 6 years ago

Dang that's πŸ”₯. I'll check it out this weekend and as long as it doesn't break prior compatibility I'll merge it and put out an update.

waxfingers commented 6 years ago

Seems to be working (macos 10.13.3)... so cool and I had given up on Flashlight and MySimbl, back from the dead and hungry as hell!!! Thank you @krystofcelba and @w0lfschild πŸ™βš‘οΈπŸ„πŸŒ±πŸ‰

krystofcelba commented 6 years ago

@w0lfschild I've just tested it on macOS 10.12 and seems work well too. Unfortunately, I don’t have access to an older system where I could prove it. I could probably add some runtime checks, so it uses the old methods in case the new ones are not available.

@waxfingers Good to hear πŸ™‚. In my opinion, there isn't still anything which could concur Flashlight. I'm thinking of that would be great to reinstate some of its infrastructures so it will be easier to bring up new things etc. Something like "Flashlight Reloaded" πŸ˜„.

waxfingers commented 6 years ago

Yup REloAD alright!! I got drunk and lost, went on knocking at zazu, cerebro, alfred, lacona and even launchbar's door... just to end up drinking alone in a cold, empty alley... there's something about flashlight, a dynamic sparkle, something about the way it crawls and wants to live through the OS' mother tree... that is beautiful, frightening, inspiring and unique... well maybe it's just me πŸ’{emoji copied through FL's plugin} ,-)

Even xtrafinder came back from the dead through FL xtrafinder_flashlight_mysimbl_web

mkormendy commented 6 years ago

What the hell?

krystofcelba commented 6 years ago

@w0lfschild I've committed some changes, it now checks the OS version and reloads the results differently only on ^10.13, so it now shouldn't break anything in prior OS versions hopefully πŸ™.

@waxfingers I've thought that I’m reading part of Howl for a little while πŸ‘ πŸ˜…. But I think that I had very similar experience.

faicker commented 6 years ago

work like a charm for 10.13.3 πŸ˜„

chenghuzi commented 6 years ago

@krystofcelba Thanks for doing this! I've test the new build, and it works well with my MBP2015. But after a restart, the flashlight start not working again. Such thing happened occasionally before flashlight didn't work on macOS 10.13. Do you have any idea on this issue?

System info: macOS 10.13.4 Beta

Update:

After reinstalling flashlight (re-init SpotlightSIMBL), all plugins works well. The problem might be the loading part of SpotlightSIMBL.

tsimmons commented 6 years ago

I haven't been able to build Flashlight; I tried cloning the project and checking out your PR (#41) but when I try to build, I get errors:

ld: warning: directory not found for option '-L/Users/_xxx/Library/Developer/Xcode/DerivedData/Flashlight-djbjtmwjieqmmvehsncvbijtmdsb/Build/Products/Debug/GRMustache'
ld: warning: directory not found for option '-L/Users/_xxx/Library/Developer/Xcode/DerivedData/Flashlight-djbjtmwjieqmmvehsncvbijtmdsb/Build/Products/Debug/JRSwizzle'
ld: warning: directory not found for option '-L/Users/_xxx/Library/Developer/Xcode/DerivedData/Flashlight-djbjtmwjieqmmvehsncvbijtmdsb/Build/Products/Debug/LetsMove'
ld: warning: directory not found for option '-L/Users/_xxx/Library/Developer/Xcode/DerivedData/Pods-gpoaxpycjinulnbzpvilkgtvohcj/Build/Products/Debug'
ld: library not found for -lGRMustache

This is on Sierra using XCode 9.2. Any advice?

YonatanAhituv commented 6 years ago

@tsimmons you need to run the python script in the root directory. You'll need to remove the code for signing flashlight though. Had the same issue at first.

technolingo commented 6 years ago

Do I also need to install Xcode?

w0lfschild commented 6 years ago

The update by @krystofcelba is now live so all you need to do is update in app or download the latest version from my repo.

mkormendy commented 6 years ago

Does this also fix the other plugins? FullscreenER seems to not be working still.

w0lfschild commented 6 years ago

@mkormendy

This project does not have to do with mySIMBL plugins. Also FullscreenER does work on 10.13.4 so the issue is probably on your end.

jcadogan commented 6 years ago

So I loved the flashlight with the simple install, and would love to use the updated one by @krystofcelba but am very new to the whole GitHub scene. Can anyone point me in the direction of a guide or any tips on how to install the updated version? I LOVE Flashlight, and would love to get it working on high sierra!

YonatanAhituv commented 6 years ago

@jcadogan Just follow the instructions in the README. The fix is out.

samlowry commented 6 years ago

@krystofcelba High Sierra 10.13.4, all installed by readme but not works. Rebooted for sure.

BTW, is mySIMBL.app have to ask permissions for upgrading some components every start? Is it normal?

w0lfschild commented 6 years ago

@samlowry If it's asking every start then it's probably failing to install the components in the first place, without the mySIMBL aspect fully installed Flashlight wont work at all.

d4hines commented 6 years ago

@w0lfschild, I'm having the same issue as @samlowry on 10.13.6 - I've installed mySimbl, but it asks for permissions every time

screen shot 2018-08-12 at 7 32 33 pm

And no flashlight plugins seem to work screen shot 2018-08-12 at 7 33 50 pm

Any special steps I need to take? This would be so awesome to get working!

MrDavidG commented 6 years ago

@w0lfschild @d4hines, the same issue with you, and my version is also 10.13.6.

nooorris commented 6 years ago

@w0lfschild @MrDavidG I got the same problem, and my version is 10.13.1