search

w0ng / vim-hybrid

A dark color scheme for Vim
1.48k stars 234 forks source link

Html errors are nearly invisible with "set cursorline" #1

Closed Zer0- closed 11 years ago

Zer0- commented 11 years ago

If you have an html file with an extra '>' that symbol (closes a tag that's never opened) is nearly invisible. The html syntax thinks its an error and errors are fg_background on bg_red, but with cursorline is invisible. This is particularly bad if you're using sparkup or zencoding which uses the ">" symbol a lot.

I changed this line: exe "hi! Error" .s:fg_background .s:bg_red .s:fmt_none

to: exe "hi! Error" .s:fg_red .s:bg_background .s:fmt_none

and that solved the issue, but I don't know how this will look when editing other filetypes.

w0ng commented 11 years ago

Did a quick Google. Seems like an issue with background colours on the same row as the cursor, when cursorline is enabled:

https://groups.google.com/forum/?fromgroups=#!topic/vim_dev/RscKIpSI3iA http://vim.1045645.n5.nabble.com/CursorLine-and-SpellBad-colors-interfere-td2636169.html

I'll make the updates to Error and Spell* colours later tonight.

w0ng commented 11 years ago

Using underlines instead of background colour, so that spelling highlights and error highlights are distinguishable from syntax highlighting.

4126ce8f2eb4649afab7820a514bfe4c1891c6b9