search

w0ng / vim-hybrid

A dark color scheme for Vim
1.48k stars 235 forks source link

darken tabline to make it consistent with line number #18

Closed mrhooray closed 6 years ago

mrhooray commented 10 years ago

side effect of change on highlighting title?

w0ng commented 9 years ago

I personally don't use tabs.

I'm happy to change the TabLine* highlightings if there's an alternative to changing Title.

Title is used for headings in command output e.g. :autocmd, but it's also inherited by other syntax files e.g. markdown.vim uses Title to highlight headings.

Perhaps consider updating the pull request to use a dark-grey on light-grey for the selected tab vs light-grey on dark-grey for unselected tabs, similar to StatusLine vs StatusLineNC (http://i.imgur.com/1OzsZpy.png) to indicate the current split window.

mrhooray commented 9 years ago

change on title is to get rid of abrupt yellow background shown in left tabline in original effect. i'm not familiar with vim highlighting, do you think of a way to fix it without affecting other pieces?

compared to StatusLine vs StatusLineNC, effect after pr looks more immersive with rest vim content. what do you think?

original screen shot 2015-03-10 at 11 39 03 pm after pr screen shot 2015-03-10 at 11 39 14 pm dark-grey on light-grey for the selected tab vs light-grey on dark-grey for unselected tabs screen shot 2015-03-10 at 11 46 22 pm

kepbod commented 8 years ago

I love this one.

kepbod commented 8 years ago

I really love this change. I am maintaining a vim configuration repository ivim using Hybrid colorscheme. Hybrid is the most beautiful vim colorscheme I have ever used. However, because you did not accept this pull request, I have to use his modified Hybrid in my configuration. Could you kindly accept this pull request so that I could change to use your master branch? Thanks!