w0ng / vim-hybrid

A dark color scheme for Vim
1.48k stars 235 forks source link

Merged some aspects into a unified color scheme (rebased) #30

Closed lithammer closed 8 years ago

lithammer commented 9 years ago

This is a rebased version of https://github.com/w0ng/vim-hybrid/pull/9, it was quite messy, but I think it's all there.

lithammer commented 8 years ago

@w0ng what do you think?

ghost commented 8 years ago

:+1: How's the progress on this?

lithammer commented 8 years ago

It's done from my end, just need @w0ng to take a look at it.

w0ng commented 8 years ago

@renstrom Thanks a lot for tidying this up.

Before merging, could you please remove the bling and BlingHilight references as I think it's better to keep third-party styling out of this.

Also, I think the Spell hilights need merging i.e. the darkblue, darkcyan, darkred, darkpurple colours in the dark scheme should be combined with with the addbg, addfg, changefg, changebg of the light scheme.

In #30, errors are thrown in the light version because it's attempting to set ctermbg="" for the Spell hilights.

line  299:
E254: Cannot allocate color ctermbg=
line  300:
E254: Cannot allocate color ctermbg=
line  301:
E254: Cannot allocate color ctermbg=
line  302:
E254: Cannot allocate color ctermbg=
line  367:
E254: Cannot allocate color ctermbg=
lithammer commented 8 years ago

This is what the spelling stuff look like.

term

screen shot 2015-09-26 at 17 19 26

gui

screen shot 2015-09-26 at 17 20 37

ghost commented 8 years ago

:+1: it's good to see some progress on this!! Thank you.

w0ng commented 8 years ago

Awesome thanks