search

w0rd-driven / docker-laravel-deployer

Docker image build for use with Laravel 5.x, including deployer
MIT License
2 stars 2 forks source link

Lock deployer versions? #10

Closed w0rd-driven closed 2 years ago

w0rd-driven commented 4 years ago

This is tough to address as currently the deployer version really depends on when the build is ran so it's hard to tag the versions deployed to docker in a meaningful way.

Truthfully this repo should really be docker-laravel where deployer is per project but reducing our packagist hits are a worthwhile goal to reduce any CI build times. Bypassing any apt or pecl install is a no-brainer and we should include as much as we can get away with but composer packages are the real variable that's hard to pin down. I don't know if I'll address this but I like at least noting that I have thought about it for quite some time since starting this project.

w0rd-driven commented 2 years ago

I'm abandoning this considering I wouldn't have a good solution to prior builds moving forward. It's also unfortunate that there are no more automated builds for this repo. It's unfortunate but I would suggest anyone using it have a local version of deployer that overrides the global.

I don't think it was the brightest idea to include that globally, it's better for any composer package with it as a dependency explicitly define it. Things get messy when you expect something to be on a system that may not be.