search

w0rd-driven / docker-laravel-deployer

Docker image build for use with Laravel 5.x, including deployer
MIT License
2 stars 2 forks source link

Remove supporting builds to match the official PHP image? #12

Closed w0rd-driven closed 2 years ago

w0rd-driven commented 5 years ago

It looks like the earliest supported builds in the repository are for 7.1.x onward, dropping 5.6 and 7.0 off our list.

It may be worthwhile to actually tag our local builds before we do that even though this is a little difficult to follow semver or any reasonable version of it. As of 6 days ago (9/18/2019) both 5.6 and 7.1 images built properly so I don't yet see any reason to do so but it may not be a bad idea long term.

I should research if it's possible to pull in extremely old images of these tags. I don't want the images to stop working, I just don't want to build new ones. I suspect this is likely how things are progressing now and why the earlier base images just work(tm). If I can follow the php image's lead it would be worth doing.

w0rd-driven commented 5 years ago

When I bring in 7.4 I'll drop the others. I do need to research this a lot more.

w0rd-driven commented 2 years ago

Eh, I'm leaving this. It's trivial to have the old versions around and auto build is no longer including them so it's fine to have them set in stone as it were.

Ideally, we would follow Laravel Sail's versioning.