w0rm / gulp-svgstore

Combine svg files into one with symbol elements
https://www.npmjs.com/package/gulp-svgstore
645 stars 33 forks source link

Fork or pull request for migrate to stack? #111

Closed firefoxic closed 2 years ago

firefoxic commented 2 years ago

I wanted to change the code so that the plugin generates a stack sprite instead of a symbol sprite.

But the changes turned out to be very extensive, including removing the ability to inline a sprite in the markup and rewriting tests. And given that the principle of working with the plugin changes quite a lot (although it remains possible to insert external sprite icons through the use tag), I would like to know if such changes are of interest in the form of a pull request or does it make sense to create a full-fledged renamed fork?

w0rm commented 2 years ago

@firefoxic hi. I think a fork makes more sense.

firefoxic commented 2 years ago

Done 🚀 gulp-stacksvg