search

w0rm / gulp-svgstore

Combine svg files into one with symbol elements
https://www.npmjs.com/package/gulp-svgstore
646 stars 33 forks source link

Auto display none #3

Closed maxisix closed 10 years ago

maxisix commented 10 years ago

It's a really nice gulp plugin! Is it possible to add an option to display none the SVG ?

w0rm commented 10 years ago

Hi @maxisix, thanks for trying this out!

Do you refer to inline usage? I do not see any problems with simply putting svg inside hidden div, like I did in this test case.

For features like this, I may provide callback hook that receives svg object and allows to alter it before serialisation. What do you think?

maxisix commented 10 years ago

Yea i mean inline :) . Its just i dont like to add an other div to wrap this when its possible to hide inline. You're idea seems the good one !

maxisix commented 10 years ago

I re-tried and i'am not sure its working well. I did somes socials icon (facebook, instagram, pinterest and vimeo). When i use the gulp task they all merge inside one symbol... Do you have the same problem ?

w0rm commented 10 years ago

@maxisix this is strange, can you give me these icons for a test case?

maxisix commented 10 years ago

Sure: http://cl.ly/0Y343Z2X3Y3e

w0rm commented 10 years ago

@maxisix your source svg files already contain many icons, you should save each icon into separate file.

maxisix commented 10 years ago

oh damn you're right ! My bad !! ;)

w0rm commented 10 years ago

Also closes #4