search

w0rm / gulp-svgstore

Combine svg files into one with symbol elements
https://www.npmjs.com/package/gulp-svgstore
646 stars 33 forks source link

Remove attributes #4

Closed bigandy closed 10 years ago

bigandy commented 10 years ago

Great plugin, would really like to be able to remove fill="#abc123" from svg. Can do this with the grunt plugin with cleanup: ['fill']

w0rm commented 10 years ago

@bigandy thanks for trying it out! Here is some info from my svg workflow:

I run gulp-svgstore over svgs that come from Adobe Illustrator. I asked designer to set transparent fills on all elements that need to be styled from css (this results in fill="none" svg attribute). Then I added an option to remove these fills (emptyFills: true). This allows to alter only particular elements, because some paths may need to keep their fills. cleanup: ['fill'] option from grunt plugin doesn't allow my workflow.

Maybe we can implement something different that allows to remove only particular attributes, perhaps by checking attributes against filter function? I also think that doing too much stuff inside gulp-svgstore that is controlled by many options is not the gulp way to do. So maybe export cleanup as a different stream transformation function and pass it svgs before combining them with gulp-svgstore?