w0rm / gulp-svgstore

Combine svg files into one with symbol elements
https://www.npmjs.com/package/gulp-svgstore
645 stars 33 forks source link

gulp4 alpha.3 #87

Closed jonnitto closed 6 years ago

jonnitto commented 6 years ago

If I run your plugin with gulp4 I got following error: file.isSymbolic is not a function It has to do with vinyl-fs version 3

saki007ster commented 6 years ago

@jonnitto this is happening because gulp4 alpha.3 does not support vinyl ^2.0 you might need to upgrade to vinyl ^2.1 also STOP using gulp-util - check - https://github.com/gulpjs/gulp/issues/2065

phated commented 6 years ago

@saki007ster yep, this is using an insanely old Vinyl. It needs to stop using gulp-util (now deprecated) and use vinyl directly.

w0rm commented 6 years ago

@phated if I update the plugin to use the latest vinyl, will this still work with the old gulp?