search

w0rm / gulp-svgstore

Combine svg files into one with symbol elements
https://www.npmjs.com/package/gulp-svgstore
645 stars 33 forks source link

Content loaded via ajax shows empty icons #94

Closed matthewnessworthy closed 5 years ago

matthewnessworthy commented 5 years ago

With relation to https://stackoverflow.com/questions/44245032/svg-symbols-not-loading-with-ajax-content-in-chrome

Please can you include xmlns:xlink="http://www.w3.org/1999/xlink" in the <svg/> tag definition.

Currently when content containing is loaded via ajax, icons within the content are blank.

w0rm commented 5 years ago

@matthewnessworthy can you open a PR that adds it here: https://github.com/w0rm/gulp-svgstore/blob/master/index.js#L18 and updates the tests?

matthewnessworthy commented 5 years ago

@w0rm the PR https://github.com/w0rm/gulp-svgstore/pull/96 has been created and the unit tests pass. Usage tests appear to be broken (but unrelated to the PR)

w0rm commented 5 years ago

@matthewnessworthy thanks! Just published 7.0.1. I'm not sure what's happened to the usage tests