search

w1ld3r / crypto-signal

The #1 Automated Technical Analysis (TA) & Algo. Trading tool for Coinbase, Bittrex, Binance, and more! (Track over 500+ coins)
http://cryptosignal.dev
MIT License
75 stars 36 forks source link

Haapy to be the first to ask ;) Issue with CONDITIONALS #4

Closed bluetyphoon77 closed 3 years ago

bluetyphoon77 commented 3 years ago

Hi again ;)

I've followed your example and it does not work, I still get the individuals notifs.

Is there something I mae wrong ? HEre is my config:

config.txt

thanks in advance for your help

w1ld3r commented 3 years ago

It's better if you use this config file (the one in the documentation).

The one you've found was just for dev/debug purpose an so, it's not working with the current release.

settings:
  log_level: INFO
  update_interval: 120
  start_worker_interval: 2
  market_data_chunk_size: 1
  timezone: Europe/Paris

exchanges:
  kraken:
    required:
      enabled: true
    all_pairs:
      - USD

indicators:
  rsi:
    - enabled: true
      alert_enabled: true
      alert_frequency: always
      signal:
        - rsi
      hot: 30
      cold: 70
      candle_period: 1h
      period_count: 14
    - enabled: true
      alert_enabled: true
      alert_frequency: always
      signal:
        - rsi
      hot: 40
      cold: 60
      candle_period: 1d
      period_count: 14
  bollinger:
    - enabled: true
      candle_period: 1h
      alert_enabled: true
      alert_frequency: always
      period_count: 25
      std_dev: 2.5
      signal:
        - low_band
        - close
        - up_band
      mute_cold: false
    - enabled: true
      candle_period: 1d
      alert_enabled: true
      alert_frequency: always
      period_count: 25
      std_dev: 2.5
      signal:
        - low_band
        - close
        - up_band
      mute_cold: false
  aroon_oscillator:
    - enabled: true
      alert_enabled: true
      alert_frequency: always
      sma_vol_period: 50
      period_count: 14
      signal:
        - aroon
      candle_period: 1h

conditionals:
  - label: "Signal to buy"
    hot:
      - rsi: 0
      - rsi: 1
    cold:
      - bollinger: 0
  - label: "Signal to buy"
    hot:
      - rsi: 1
  - label: "Signal to sell"
    cold:
      - rsi: 1
      - rsi: 0
    hot:
      - aroon_oscillator: 0

notifiers:
    telegram:
        required:
            token: X
            chat_id: Y
        optional:
            parse_mode: html
            template: "[{{market}}] {{indicator}} {{status}} {{values}} {{ '\n' -}}"

Just replace the X and Y with your token and chat id.

You can also modify the timezone if you don't live in Paris.

bluetyphoon77 commented 3 years ago

Thanks I've tested it. Like you see on my config upload, I use the right values and setings.

Why do I still get individual notifs when I set conditional ?

I'm in Brussels 😉 so ok 😉

From: w1ld3r notifications@github.com Sent: Wednesday, December 2, 2020 1:10 PM To: w1ld3r/crypto-signal crypto-signal@noreply.github.com Cc: bluetyphoon77 magicyvan@hotmail.com; Author author@noreply.github.com Subject: Re: [w1ld3r/crypto-signal] Haapy to be the first to ask ;) Issue with CONDITIONALS (#4)

It's better if you use this config file (the one in the documentation).

The one you've found was just for dev/debug purpose an so, it's not working with the current release.

settings: log_level: INFO update_interval: 120 start_worker_interval: 2 market_data_chunk_size: 1 timezone: Europe/Paris

exchanges: kraken: required: enabled: true all_pairs:

indicators: rsi:

conditionals:

notifiers: telegram: required: token: X chat_id: Y optional: parse_mode: html template: "[{{market}}] {{indicator}} {{status}} {{values}} {{ '\n' -}}"

Just replace the X and Y with your token and chat id.

You can also modify the timezone if you don't live in Paris.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/w1ld3r/crypto-signal/issues/4#issuecomment-737220770, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AJEEGYA7T2YGEOSOKFVVIRTSSY4EZANCNFSM4UKO22OA.

w1ld3r commented 3 years ago

It's because you have to modify app/defaults.yml and set alert_enabled: true to alert_enabled: false or in your app/config.yml define all indicators in app/defaults.yml and set them to enabled: false if you don't need infos on them or alert_enabled: false if you don't want to receive notifications.

bluetyphoon77 commented 3 years ago

To simplify ;) If I set alert_enabled: false in my config for each individual indicator (rsi and mfi for example) I will ONLY get the conditional notifs ?

w1ld3r commented 3 years ago

No you have to set alert_enabled to false only for indicators you don't want to receive notifications. If you want, when I come back home, I can give you an example of the app/defaults.yml to use with the config file given above.

bluetyphoon77 commented 3 years ago

ok thanks. I've tested again, and still not getting the conditional labeled notif ;) In my config as you can see I've set everything else to false, so notif are fast ! This si great. But still not succeeding to make it work for conditionals ! Does it mean I have to setup things in defaults ? rather than my personal config ??? ok See you later then, thanks

w1ld3r commented 3 years ago

Try this config.yml:

settings:
  log_level: INFO
  update_interval: 900
  start_worker_interval: 2
  market_data_chunk_size: 1
  timezone: Europe/Paris

exchanges:
  kraken:
    required:
      enabled: true
    all_pairs:
      - EUR
    exclude:
      - XBTEUR.d
      - ETHEUR.d
      - USDC
      - USDT
      - MLN

indicators:
  rsi:
    - enabled: true
      alert_enabled: true
      alert_frequency: multi
      signal:
        - rsi
      hot: 30
      cold: 70
      candle_period: 1h
      period_count: 14
    - enabled: true
      alert_enabled: true
      alert_frequency: multi
      signal:
        - rsi
      hot: 40
      cold: 60
      candle_period: 1d
      period_count: 14
    - enabled: true
      alert_enabled: true
      alert_frequency: multi
      signal:
        - rsi
      hot: 30
      cold: 70
      candle_period: 1d
      period_count: 14
  momentum:
    - enabled: false
      alert_enabled: false
  mfi:
    - enabled: false
      alert_enabled: false
  obv:
    - enabled: false
      alert_enabled: false
  stoch_rsi:
    - enabled: false
      alert_enabled: false
  macd_cross:
    - enabled: true
      candle_period: 1d
      alert_enabled: true
      alert_frequency: always
      signal:
        - macd
        - signal
      mute_cold: false
  ichimoku:
    - enabled: false
      alert_enabled: false
  iiv:
    - enabled: false
      alert_enabled: false
  ma_crossover:
    - enabled: true
      candle_period: 1d
      alert_enabled: true
      alert_frequency: once
      exponential: true
      ma_fast: 50
      ma_slow: 120
      signal:
        - open
        - close
  bollinger:
    - enabled: true
      candle_period: 1h
      alert_enabled: true
      alert_frequency: always
      period_count: 25
      std_dev: 2.5
      signal:
        - low_band
        - close
        - up_band
      mute_cold: false
    - enabled: true
      candle_period: 1d
      alert_enabled: true
      alert_frequency: always
      period_count: 25
      std_dev: 2.5
      signal:
        - low_band
        - close
        - up_band
      mute_cold: false
  aroon_oscillator:
    - enabled: true
      alert_enabled: true
      alert_frequency: always
      sma_vol_period: 50
      period_count: 14
      signal:
        - aroon
      candle_period: 1h

informants:
    lrsi:
        - enabled: false
    vwap:
        - enabled: false
    sma:
        - enabled: false
    ema:
        - enabled: false
          alert_enabled: false
    bollinger_bands:
        - enabled: false
    ohlcv:
        - enabled: false

conditionals:
  - label: "Buy short"
    hot:
      - rsi: 0
      - rsi: 1
      - bollinger: 0
    cold:
      - aroon_oscillator: 0

notifiers:
    telegram:
        required:
            token: X
            chat_id: Y
        optional:
            parse_mode: html
            template: "[{{market}}] {{indicator}} {{status}} {{values}} {{ '\n' -}}"
bluetyphoon77 commented 3 years ago

Just tried. I'm getting all the notifications !

w1ld3r commented 3 years ago

Only conditional notifications ?

bluetyphoon77 commented 3 years ago

no only normal notifs 😉

[cid:4c05803b-6e65-4665-ae34-da9b67350946]

From: w1ld3r notifications@github.com Sent: Wednesday, December 2, 2020 9:01 PM To: w1ld3r/crypto-signal crypto-signal@noreply.github.com Cc: bluetyphoon77 magicyvan@hotmail.com; Author author@noreply.github.com Subject: Re: [w1ld3r/crypto-signal] Haapy to be the first to ask ;) Issue with CONDITIONALS (#4)

Only conditional notifications ?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/w1ld3r/crypto-signal/issues/4#issuecomment-737492579, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AJEEGYEL7O6MSOQBAF4NB2DSS2TJ3ANCNFSM4UKO22OA.

w1ld3r commented 3 years ago

The only things that can cause this is that you are not using my fork

bluetyphoon77 commented 3 years ago

I've followed your installation steps. Then I did : docker build -t dev/crypto-signals:latest . docker run --rm -ti -v $PWD/app:/app dev/crypto-signals:latest

I will redo the : git checkout develop to test it

bluetyphoon77 commented 3 years ago

git checkout develop M Dockerfile M LICENSE M Makefile M README.md M default-config.yml M docker-compose.dev.yml M docker-compose.yml Already on 'develop' Your branch is up-to-date with 'origin/develop'.

w1ld3r commented 3 years ago

Here is the steps I'm doing to reproduce your issue:

git clone https://github.com/w1ld3r/crypto-signal.git
cd crypto-signal/
touch app/config.yml && echo "settings:
  log_level: INFO
  update_interval: 900
  start_worker_interval: 2
  market_data_chunk_size: 1
  timezone: Europe/Paris

exchanges:
  kraken:
    required:
      enabled: true
    all_pairs:
      - EUR
    exclude:
      - XBTEUR.d
      - ETHEUR.d
      - USDC
      - USDT
      - MLN

indicators:
  rsi:
    - enabled: true
      alert_enabled: true
      alert_frequency: multi
      signal:
        - rsi
      hot: 100
      cold: 1
      candle_period: 1h
      period_count: 14
  momentum:
    - enabled: false
      alert_enabled: false
  mfi:
    - enabled: false
      alert_enabled: false
  obv:
    - enabled: false
      alert_enabled: false
  stoch_rsi:
    - enabled: false
      alert_enabled: false
  macd_cross:
    - enabled: false
      alert_enabled: false
  ichimoku:
    - enabled: false
      alert_enabled: false
  iiv:
    - enabled: false
      alert_enabled: false
  ma_crossover:
    - enabled: false
      alert_enabled: false
  bollinger:
    - enabled: false
      alert_enabled: false
  aroon_oscillator:
    - enabled: false
      alert_enabled: false

informants:
    lrsi:
        - enabled: false
    vwap:
        - enabled: false
    sma:
        - enabled: false
    ema:
        - enabled: false
          alert_enabled: false
    bollinger_bands:
        - enabled: false
    ohlcv:
        - enabled: false

conditionals:
  - label: test 1
    hot:
      - rsi: 0
  - label: test 2
    cold:
      - rsi: 0

notifiers:
    telegram:
        required:
            token: X
            chat_id: Y
        optional:
            parse_mode: html
            template: \"[{{market}}] {{indicator}} {{status}} {{values}} {{ '\n' -}}\"" > app/config.yml
docker build -t dev/crypto-signals:latest .
docker run --rm -ti -v $PWD/app:/app dev/crypto-signals:latest

And every things is working fine ...

bluetyphoon77 commented 3 years ago

In the first step of your installation you say to clone THIS REPO :

Be sure you have git installed in your system.

  1. Clone this repo git clone https://github.com/CryptoSignal/crypto-signal.git

So is it an error in your installation steps ?

From: w1ld3r notifications@github.com Sent: Wednesday, December 2, 2020 9:21 PM To: w1ld3r/crypto-signal crypto-signal@noreply.github.com Cc: bluetyphoon77 magicyvan@hotmail.com; Author author@noreply.github.com Subject: Re: [w1ld3r/crypto-signal] Haapy to be the first to ask ;) Issue with CONDITIONALS (#4)

Here is the steps I'm doing to reproduce your issue:

git clone https://github.com/w1ld3r/crypto-signal.git cd crypto-signal/ echo "settings: log_level: INFO update_interval: 900 start_worker_interval: 2 market_data_chunk_size: 1 timezone: Europe/Paris

exchanges: kraken: required: enabled: true all_pairs:

indicators: rsi:

informants: lrsi:

conditionals:

notifiers: telegram: required: token: X chat_id: Y optional: parse_mode: html template: \"[{{market}}] {{indicator}} {{status}} {{values}} {{ '\n' -}}\"" > app/config.yml docker build -t dev/crypto-signals:latest . docker run --rm -ti -v $PWD/app:/app dev/crypto-signals:latest

And every things is working fine ...

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/w1ld3r/crypto-signal/issues/4#issuecomment-737503179, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AJEEGYHIDR4K63ZHNQW23GLSS2VXPANCNFSM4UKO22OA.

w1ld3r commented 3 years ago

Yes but it's the README of the main project and I haven't touch it

bluetyphoon77 commented 3 years ago

LOL .... Ok so this is the problem LOL I'm sorry but I followed the steps in YOUR repo ;) I did not think about this... very sorry !! So I do not need to git the main one, I just git yours right ?

w1ld3r commented 3 years ago

Yes. I've modify the README to not mislead.

bluetyphoon77 commented 3 years ago

Great ! It will help beginners like me ;) By the way you speak french ? are you french ? ;) PS: I still need to find how to get accurat results with stochrsi if you don't mind ....

w1ld3r commented 3 years ago

I don't think I will have time, the next few month, to take a look at this issue ... Happy that everything is' working for you now !

zooz124 commented 3 years ago

Hello, i supose 1 condition (label) is the max right? i tried 2 labels but only one works, the last one always.

w1ld3r commented 3 years ago

Hello @zooz124, ou can have as many condition you want. The label will just replace the {{status}} value for a notification. I you only get alert for your second condition it's because the first one is never triggered. Don't hesitate to share your config.yml file for adjustement ;)

zooz124 commented 3 years ago

Hi thanks for responding quickly, fist of all i changed some files with the help of this: https://github.com/CryptoSignal/Crypto-Signal/commit/069cc314466bb6ddba78dc36c41aa1e7111f222c

That was necessary or your current git is fully prepared for conditionals? thank you very much.

w1ld3r commented 3 years ago

You can use my fork, it's fully working with new changes of the main branch.

zooz124 commented 3 years ago

@w1ld3r Thank you very much! It worked finally, awesome job man.

Do you have in mind to implement divergences (macd,rsi,price) in the future, I think it would be very helpful.

w1ld3r commented 3 years ago

Glad to know you like it. It can be great yes. If you like create a Feature request issue.