search

w1ld3r / crypto-signal

The #1 Automated Technical Analysis (TA) & Algo. Trading tool for Coinbase, Bittrex, Binance, and more! (Track over 500+ coins)
http://cryptosignal.dev
MIT License
76 stars 37 forks source link

[BUG] not getting the right STOCHRSI values #6

Closed bluetyphoon77 closed 3 years ago

bluetyphoon77 commented 3 years ago

Describe the bug I've asked the bot to get the 3 STOCHRSI values (stochrsi, k, d) and all are wrong

To Reproduce Easy. Just tell me if you have the right one yourself. It has nothing to do with installation. Probably how we set up STOCH .. and WHAT we can set up to have accuracy.

Expected behavior Check this. When bot started. I get for example for HBAR/USDT on binance stoch_rsi #0: 81.90397794/68.25484126/60.94965080 first = stoch, then k, then d

In tradingview k = 56.30 d = 46.47

So, TOTALLY WRONG ... weird.... not even ONE value matches !

config.yml

# Copy this file to config.yml to get started and then add your own configuration.
# Full documentation here: https://github.com/CryptoSignal/crypto-signal/blob/master/docs/config.md

settings:
  log_level: INFO
  update_interval: 3600
  timezone: Europe/Paris
  market_pairs:
    - THETA/BTC
    - UTK/USDT
    - VIA/BTC
    - POWR/BTC
    - NXS/BTC
    - NAV/BTC
    - STEEM/BTC
    - VIB/BTC
    - BCPT/BTC
    - DGB/BTC
    - APPC/BTC
    - SNX/USDT
    - KNC/USDT
    - ICX/USDT
    - HBAR/USDT

exchanges:
  binance:
    required:
      enabled: true

notifiers:
    telegram:
        required:
            token: 
            chat_id: 
        optional:
            parse_mode: html
            template: "{{exchange}} - {{market}} - {{indicator_label}} - {{values}} - {{hot_cold_label}} - {{conditionals}}  "

indicators:
    rsi:
        - enabled: true
          alert_enabled: true
          alert_frequency: always
          signal:
            - rsi
          hot: 40
          cold: 75
          hot_label: 'GOOD buy opportunity!'
          cold_label: 'GOOD sell opportunity!'
          indicator_label: 'RSI Daily'
          candle_period: 1d
          period_count: 14
          mute_cold: false

    mfi:
        - enabled: true
          alert_enabled: true
          alert_frequency: always
          signal:
            - mfi
          hot: 25
          cold: 75
          hot_label: 'GOOD buy opportunity!'
          cold_label: 'GOOD sell opportunity!'
          indicator_label: 'MFI Daily'
          candle_period: 1d
          period_count: 12
          mute_cold: false

    stoch_rsi:
        - enabled: true
          alert_enabled: true
          alert_frequency: always
          signal:
            - stoch_rsi
            - slow_k
            - slow_d         
          hot: 25
          cold: 80
          hot_label: 'GOOD buy opportunity!'
          cold_label: 'GOOD sell opportunity!'
          indicator_label: 'STOCH Daily'
          candle_period: 1d
          period_count: 14
          mute_cold: false

    macd:
        - enabled: false
    momentum:
        - enabled: false
    obv:
        - enabled: false    
    ichimoku:
        - enabled: false
    iiv:
        - enabled: false

informants:
    lrsi:
        - enabled: false
    vwap:
        - enabled: false
    sma:
        - enabled: false
    ema:
        - enabled: false
    bollinger_bands:
        - enabled: false
    ohlcv:
        - enabled: false

conditionals:  
  - label: "2 CHECKMARKS for a GOOD sell"
    cold:
      - stoch_rsi: 0
    cold:
      - mfi: 0

Desktop

DONE ! As you asked. Hope you'll be able to help thanks PS: I just removed telgram info

w1ld3r commented 3 years ago

Ok I will take a look when I get some time

bluetyphoon77 commented 3 years ago

thanks a lot 😉

From: w1ld3r notifications@github.com Sent: Wednesday, December 2, 2020 2:02 PM To: w1ld3r/crypto-signal crypto-signal@noreply.github.com Cc: bluetyphoon77 magicyvan@hotmail.com; Author author@noreply.github.com Subject: Re: [w1ld3r/crypto-signal] [BUG] ... not getting the right STOCHRSI values (#6)

Ok I will take a look when I get some time

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/w1ld3r/crypto-signal/issues/6#issuecomment-737248363, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AJEEGYBYF6G55HDPYV52DMLSSZCG5ANCNFSM4UKQPCKA.

bluetyphoon77 commented 3 years ago

I just tested again with simple settings : just STOCHRSI

settings: log_level: INFO update_interval: 3600 timezone: Europe/Paris market_pairs:

exchanges: binance: required: enabled: true

notifiers: telegram: required: token: chat_id: optional: parse_mode: html template: "{{market}} - {{values}} - {{hot_cold_label}} "

indicators: stoch_rsi:

informants: lrsi:

This is what I get when I use the code you sent me NOW on the 6/12/2020, at 14:23 UTC+1 (PAris time)

Beginning analysis of LINK/USDT LINK/USDT: indicators: stoch_rsi #0: 6.19683765

HBAR/USDT: indicators: stoch_rsi #0: 41.81868073

DGB/BTC: indicators: stoch_rsi #0: 19.01127194

VIA/BTC: indicators: stoch_rsi #0: 49.36108561

POWR/BTC: indicators: stoch_rsi #0: 34.24612329

When I check on binance or tradingview at the same moment I have (for a stochrsi of k=3, d=4, length 14, stoch 14)

LINK: 7.22 for K/16.92 for D HBAR: 31.31/58.82 DGB: 2.72/27.01 VIA: 36.94/52.39 POWR: 17.86/49.47

SO, you can see, totally wrong values !

bluetyphoon77 commented 3 years ago

Here is how to fix your problem in order to have the RIGHT STOCHRSI VALUE ;) https://github.com/mrjbq7/ta-lib/commit/3f872e3ff53a2ef0fa85c9ed8da66515001b2eed#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5 Keep me posted please when it is fixed ;) cheeers

w1ld3r commented 3 years ago

Fix have been push.