search

w1ld3r / crypto-signal

The #1 Automated Technical Analysis (TA) & Algo. Trading tool for Coinbase, Bittrex, Binance, and more! (Track over 500+ coins)
http://cryptosignal.dev
MIT License
76 stars 37 forks source link

[BUG] defaults.yml in documentation #63

Open kartun83 opened 9 months ago

kartun83 commented 9 months ago

In documentation it's not stated that values from config.yml overwrite structure of defaults.yml. So, if in defaults.yml some indicator is enabled, but in config.yml it's not defined (the expected behavior = disabled) value is taken from defaults.yml. This, in turn leads to consequences - price_values for notification is calculated only if ohlcv for same period is explicitly enabled

kartun83 commented 9 months ago

Found another glitch between defaults.yml and config.yml:

defaults.yml

  obv:
    - enabled: true
      alert_enabled: true
      alert_frequency: once
      signal:
        - obv
      hot: 0
      cold: 0
      candle_period: 1d
  ohlcv:
    - enabled: true
      signal:
        - close
      candle_period: 1d
      period_count: 15

config.yml

obv - not defined
  ohlcv:
    - enabled: true
      signal:
        - close
      candle_period: 5m
      period_count: 15

price_values for notification for obv is not available