search

w1ll1am23 / pyeconet

Python 3 interface to the EcoNet API
MIT License
34 stars 18 forks source link

fix: typo in refresh_equipment #29

Closed xavierd closed 1 year ago

xavierd commented 1 year ago

Reading the code, I noticed that an undefined method was being called.

w1ll1am23 commented 1 year ago

Nice! Good catch. Assuming y'all have tested this and its all working? I don't have the capacity to test it now, but I can get this merged and get a fix version out there.

CodingSquirrel commented 1 year ago

I didn't do a full test, just checked some of the lines in a terminal to check the keys matched serial, and double checked reading over the code. If you'd prefer better testing before merging I can do some more thorough testing.

w1ll1am23 commented 1 year ago

Ehh we can merge it, doesn't break anything until someone bumps the Home Assistant version.

Is the change on the HA side something one of you will be opening? If so, you can just test it out when making that change.

CodingSquirrel commented 1 year ago

I think my suggested change got left out of the merged change. I can submit as a separate PR.

w1ll1am23 commented 1 year ago

Ugh sorry yeah I forgot you left that comment my bad shouldn't have been looking at that on mobile.