search

w1nk / node-odbc

unixODBC bindings for node
MIT License
90 stars 101 forks source link

is this nan 2.0.0 related? which was published 7/31 #92

Closed amcintyre99 closed 9 years ago

amcintyre99 commented 9 years ago

$ npm install odbc \

odbc@1.1.6 install /home/andrew/dma/prd/node_modules/odbc node-gyp configure build

make: Entering directory `/home/andrew/dma/prd/node_modules/odbc/build' CXX(target) Release/obj.target/odbc_bindings/src/odbc.o ../src/odbc.cpp: In static member function ‘static void ODBC::New(const v8::FunctionCallbackInfov8::Value&)’: ../src/odbc.cpp:143:34: error: call of overloaded ‘NanThrowError(v8::Localv8::Object&)’ is ambiguous return NanThrowError(objError); ^ ../src/odbc.cpp:143:34: note: candidates are: In file included from ../src/odbc.h:23:0, from ../src/odbc.cpp:25: ../node_modules/nan/nan.h:705:21: note: void NanThrowError(v8::Handlev8::String) NAN_INLINE void NanThrow ## NAME(v8::Handlev8::String errmsg) { \ ^ ../node_modules/nan/nan.h:711:3: note: in expansion of macro ‘X’

amcintyre99 commented 9 years ago

yep, did a clone and changed package.json nan to 1.8.4 and all good

bzuillsmith commented 9 years ago

Thanks, just submitted a pull request with a hot fix. Seems nan broke something before their major version change.

wankdanker commented 9 years ago

Thank you both! Published v1.1.7 to npm.