Update for nan 2.0 API changes (io.js 3.x - node.js 4.0)

w1nk / node-odbc

unixODBC bindings for node

MIT License

90 stars 102 forks source link

Update for nan 2.0 API changes (io.js 3.x - node.js 4.0) #93

Closed leodutra closed 9 years ago

leodutra commented 9 years ago

nan was updated to 2.0 and supports V8 changes in io.js 3.x.

This new API will be determinant for node.js 4.0

bzuillsmith commented 9 years ago

Yep, just need someone to get it compiling with 2.0.

leodutra commented 9 years ago

Temporary fix: restrict supported node engine on package.json (https://github.com/deckar01/node-odbc/commit/24b4e0b1731233c57e397f9c0bb24709c33642c5).

wankdanker commented 9 years ago

Just released odbc@1.2.0 which compiles and passes tests with current nan and node@0.8.28, node@0.10.40, node@0.12.7, node@4.0.0, node@4.1.0, node@4.1.1 but has not been extensively tested for memory leaks or things of that nature.

leodutra commented 9 years ago

A whole day running SQL on BlazingSquirrel web SQL client.

No signal of memory leaks serving on Ubuntu 14.04.3 with IBM DB2 CLI Driver 10.x. And I'm talking about more than 10 million registers at least.

Awesome, Dan.

wankdanker commented 9 years ago

Awesome. Glad to hear it!