search

w33ble / rison-node

Apache License 2.0
22 stars 3 forks source link

Provide TypeScript definitions #1

Open legrego opened 6 years ago

legrego commented 6 years ago

Adding TS definitions would help with type safety

fabio-looker commented 6 years ago

Is this what would need to be added? https://www.npmjs.com/package/@types/rison https://github.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/rison

legrego commented 6 years ago

Yep, I think those typedefs would end up working for this. We'd just need to re-publish under @types/rison-node, or include those typedefs directly in this repository. I prefer the latter approach, as it's one less dependency to maintain in downstream projects

w33ble commented 6 years ago

I'm also in favor of pulling types into this repo, less dependencies and also easier to keep things in sync.

tiffon commented 2 years ago

Btw decode_uri is not in the linked typedefs since it is specific to rison-node.

https://github.com/DefinitelyTyped/DefinitelyTyped/blob/761c11c125ae9acf6d9450959f13c01bb1c3e6f1/types/rison/index.d.ts#L32-L36