search

w3b3d3v / kyodo-protocol

https://kyodo-protocol-mvp.vercel.app
MIT License
12 stars 5 forks source link

Fee Restructure and Bulk Payment Implementation #188

Closed nomadbitcoin closed 11 months ago

nomadbitcoin commented 11 months ago
  1. Fees are now paid by the payer.
  2. Removed Vault dependency.
  3. Removed community fee logic and stripped out TOTAL_FEE.
  4. Front-end updated to new fee calculation for approvals.
  5. Enabled bulk payment processing.

Closes #184 Closes #149 Closes #185

vercel[bot] commented 11 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
kyodo-protocol ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 24, 2023 6:57pm
danicuki commented 11 months ago

error: cannot estimate gas; transaction may fail or may require manual gas limit [ See: https://links.ethers.org/v5-errors-UNPREDICTABLE_GAS_LIMIT ] (reason="execution reverted", method="estimateGas", transaction={"from":"0xf9aD3D930AB5df972558636A2B8749e772aC9297","to":"0x36D20ACa29B8901Eb4AE9Fcd82cD467a046fb71c","data":"0x0778c358000000000000000000000000000000000000000000000000000000000000006000000000000000000000000000000000000000000000000000000000000000a000000000000000000000000055001429cfa759e94d2067f417df0ee232e96e1a0000000000000000000000000000000000000000000000000000000000000001000000000000000000000000000000000000000000000000000000000000000200000000000000000000000000000000000000000000000000000000000000010000000000000000000000000000000000000000000000000de0b6b3a7640000","accessList":null}, error={"code":-32603,"message":"Internal JSON-RPC error.","data":{"code":-32000,"message":"execution reverted"},"stack":"{\n \"code\": -32603,\n \"message\": \"Internal JSON-RPC error.\",\n \"data\": {\n \"code\": -32000,\n \"message\": \"execution reverted\"\n },\n \"stack\": \"Error: Internal JSON-RPC error.\n at new i (chrome-extension://nkbihfbeogaeaoehlefnkodbefgpgknn/common-3.js:16:10940)\n at s (chrome-extension://nkbihfbeogaeaoehlefnkodbefgpgknn/common-3.js:16:13880)\n at Object.internal (chrome-extension://nkbihfbeogaeaoehlefnkodbefgpgknn/common-3.js:16:14490)\n at c (chrome-extension://nkbihfbeogaeaoehlefnkodbefgpgknn/background-0.js:7:44976)\n at chrome-extension://nkbihfbeogaeaoehlefnkodbefgpgknn/background-0.js:7:45978\n at async chrome-extension://nkbihfbeogaeaoehlefnkodbefgpgknn/background-4.js:12:53970\"\n}\n at new i (chrome-extension://nkbihfbeogaeaoehlefnkodbefgpgknn/common-3.js:16:10940)\n at s (chrome-extension://nkbihfbeogaeaoehlefnkodbefgpgknn/common-3.js:16:13880)\n at Object.internal (chrome-extension://nkbihfbeogaeaoehlefnkodbefgpgknn/common-3.js:16:14490)\n at c (chrome-extension://nkbihfbeogaeaoehlefnkodbefgpgknn/background-0.js:7:44976)\n at chrome-extension://nkbihfbeogaeaoehlefnkodbefgpgknn/background-0.js:7:45978\n at async chrome-extension://nkbihfbeogaeaoehlefnkodbefgpgknn/background-4.js:12:53970"}, code=UNPREDICTABLE_GAS_LIMIT, version=providers/5.7.2)

when I try on Core Network

danicuki commented 11 months ago

There needs to be some way to show on the front end the calculation of the value (paid amount + fee) before opening MetaMask for approval. As it is, it seems strange to the user, who chooses to pay a certain amount and then another amount appears when they open the wallet

danicuki commented 11 months ago

For next PRs, let's try to make one PRs per issue and treat them separately. One PR per feature please

nomadbitcoin commented 11 months ago

Contracts updated on Core Network, please try it again