search

w3c-ccg / data-integrity-test-suite-assertion

Library for Data Integrity related test suites
1 stars 1 forks source link

Ensure tests exist that fail for inputs that have undefined terms and / or relative URLs #56

Open dlongley opened 3 months ago

dlongley commented 3 months ago

The most common relative URL mistake looks like:

"type": [..., "SomeUndefinedType"]

So we should make sure to cover that.

aljones15 commented 3 days ago

Suite now contains:

When deserializing to RDF, implementations MUST ensure that the base URL is set to null.

https://github.com/w3c-ccg/data-integrity-test-suite-assertion/blob/1f5c835edf8607d88d6e10776ebf1791828902fa/vc-generator/generators.js#L432-L449

the context is deleted in a clean up step.

and

Implementations that use JSON-LD processing, such as RDF Dataset Canonicalization [RDF-CANON], MUST throw an error, which SHOULD be DATA_LOSS_DETECTION_ERROR, when data is dropped by a JSON-LD processor, such as when an undefined term is detected in an input document.

https://github.com/w3c-ccg/data-integrity-test-suite-assertion/blob/1f5c835edf8607d88d6e10776ebf1791828902fa/vc-generator/generators.js#L267-L275

LMK if that is enough to close this issue.