search

w3c-ccg / did-spec

Please see README.md for latest version being developed by W3C DID WG.
https://w3c.github.io/did-core/
Other
124 stars 45 forks source link

Clarify PubKey section #162

Closed rhiaro closed 5 years ago

rhiaro commented 5 years ago

Cherry picks from https://github.com/w3c-ccg/did-spec/pull/61 to incorporate feedback in the discussion.

Ready to merge now, but I have an additional proposal to clarify the "vague" text around value properties (https://github.com/w3c-ccg/did-spec/pull/61#discussion_r178646041), which is to move anything around key formats to 5., ie:

  1. Each public key MUST include id and type properties.
  2. ...
  3. Each public key MUST contain exactly one key with a value of one of: publicKeyPem, publicKeyJwk, publicKeyHex, publicKeyBase64, publicKeyBase58, or similar depending on the format and encoding of the public key. The array of public keys SHOULD NOT contain duplicate entries with the same id and different formats.

Preview | Diff

AxelNennker commented 5 years ago

Should the specification of the public key formats go into https://w3c-ccg.github.io/ld-cryptosuite-registry/ ? They are not there and there is not issue to add them.

Still, I suggest to remove the 'or similar' from the public key section. Reasons above

msporny commented 5 years ago

Should the specification of the public key formats go into https://w3c-ccg.github.io/ld-cryptosuite-registry/ ?

Yes, they should, good suggestion @AxelNennker.

Still, I suggest to remove the 'or similar' from the public key section. Reasons above

Agreed. That makes the language tighter.