Closed msporny closed 6 years ago
@peacekeeper wrote:
I could volunteer to work on these two items?
Yes, please! :)
Note that I intend to pull @peacekeeper's PR https://github.com/w3c-ccg/did-spec/pull/43 into this PR before merging into the main spec.
Merging based on CCG consensus: https://w3c-ccg.github.io/meetings/2018-01-30/#resolution-1
In the Authentication section you have "authenticationCredential" but the example shows "authentication". I thought the consensus is to use "authentication" right?
In the services section you have in the example "service" when it should be "services" to be consistent with the notes above it.
@mikelodder7 wrote:
I thought the consensus is to use "authentication" right?
Correct, and fixed here: https://github.com/w3c-ccg/did-spec/commit/684e5f828353c65d875dd5fe60a17a286af7ad83#diff-eacf331f0ffc35d4b482f1d15a887d3bL563
@mikelodder7 wrote:
In the services section you have in the example "service" when it should be "services" to be consistent with the notes above it.
We should discuss on a call. When I switched to plural form, @dlongley noted how this backfired on the Web Payments WG, so we may just want to use singular form everywhere. In any case, we should get consensus on this in the group on singular vs. plural form (in general).
I'm okay either way, but the we need the spec to be consistent, so as soon as we decide we should remember to update this to reflect the decision.
@mikelodder7 wrote:
as soon as we decide we should remember to update this to reflect the decision.
Raised an issue to remind us: https://github.com/w3c-ccg/did-spec/issues/46
Thanks @mikelodder7 :)
This PR updates the spec to reflect the latest data model based on consensus agreement reached during the DID Hardening discussions.
Preview | Diff