w3c-ccg / did-spec

Please see README.md for latest version being developed by W3C DID WG.
https://w3c.github.io/did-core/
Other
124 stars 45 forks source link

authentication section typos #52

Closed mikelodder7 closed 6 years ago

mikelodder7 commented 6 years ago

In the authentication section it says

  1. The value of the authentication property should be an array of proof mechanisms.
  2. Each proof mechanism must include id, type, and owner properties.

This is not correct, I don't see "id" or "owner 'in any of the examples and I thought the only required field is "type". Because each proof mechanism MAY be a key description of a valid public key or verification key. A new key description MAY also be defined by a DID method specification.

msporny commented 6 years ago

You're correct, this is a spec bug and needs to be fixed. Will cover in my next edit cycle. PRs appreciated.

mikelodder7 commented 6 years ago

Okay I will try to submit one.

peacekeeper commented 6 years ago

This change is already included in the PR https://github.com/w3c-ccg/did-spec/pull/50/ we're discussing right now.

msporny commented 6 years ago

This change is already included in the PR #50 we're discussing right now.

oh right, thanks @peacekeeper. You may want to "Fixes #52" in the PR so this automatically closes when we rebase + merge.