Closed haardikk21 closed 2 years ago
Thanks for updating the test vectors. I'm trying to verify them with the implementation in https://github.com/spruceid/ssi, and encounter the following:
Looking forward to discussing test vectors Thursday!
Merged via #43.
This PR introduces updated test vectors, taking into account the
types generation algorithm
(in review at https://github.com/w3c-ccg/ethereum-eip712-signature-2021-spec/pull/25).This resolves the issue mentioned in https://github.com/w3c-ccg/ethereum-eip712-signature-2021-spec/issues/24
The intention of this PR is to provide reproducible test vectors that cover the following cases:
Still consider myself relatively new to contributing to official spec work, so would appreciate any feedback and comments regarding the PR as well as regarding the structure of my introductions.
+@oed