clehner
commented
3 years ago Thanks for updating the test vectors. I'm trying to verify them with the implementation in https://github.com/spruceid/ssi, and encounter the following:
- [x] https://github.com/w3c-ccg/ethereum-eip712-signature-2021-spec/pull/26#discussion_r710072926 - Missing proof property and Proof type - Fixed in 28bd5edecde8395242aea8ba64e9be25f59585d0 with c7a3541509772818ff56c385d75cc57b778661de (https://github.com/w3c-ccg/ethereum-eip712-signature-2021-spec/pull/26#discussion_r798853853).
- [x] https://github.com/w3c-ccg/ethereum-eip712-signature-2021-spec/pull/26#discussion_r710068918 - Missing required properties in EIP-712 domain object - Fixed in https://github.com/w3c-ccg/ethereum-eip712-signature-2021-spec/pull/26#discussion_r721884685.
- [ ] https://github.com/w3c-ccg/ethereum-eip712-signature-2021-spec/pull/26#discussion_r723431682 - Missing EIP712Domain type definition. Can discuss in issue #41.
- [x] https://github.com/w3c-ccg/ethereum-eip712-signature-2021-spec/pull/26#discussion_r723409980 - Missing fragment in verification method id - Fixed in 28bd5edecde8395242aea8ba64e9be25f59585d0
- [ ] https://github.com/w3c-ccg/ethereum-eip712-signature-2021-spec/pull/26#discussion_r799759138 Unable to verify first test vector. Opened issue #42 about this.
bumblefudge
This PR introduces updated test vectors, taking into account the
types generation algorithm(in review at https://github.com/w3c-ccg/ethereum-eip712-signature-2021-spec/pull/25).This resolves the issue mentioned in https://github.com/w3c-ccg/ethereum-eip712-signature-2021-spec/issues/24
The intention of this PR is to provide reproducible test vectors that cover the following cases:
Still consider myself relatively new to contributing to official spec work, so would appreciate any feedback and comments regarding the PR as well as regarding the structure of my introductions.
+@oed