w3c-ccg / ethereum-eip712-signature-2021-spec

https://w3id.org/security/suites/eip712sig-2021
Other
16 stars 5 forks source link

Add eip712 to context #33

Closed clehner closed 2 years ago

clehner commented 3 years ago

Update JSON-LD context file for changes in #32.

Add eip712 with types, similar to previous eip712Domain with messageSchema.

I think it's okay to add to the existing v1 context rather than starting a new one, since this change should not cause breakage. The existing context definition for eip712Domain is left in the v1 file, also, to prevent breakage; if that is to be removed, I think that should be done in a new context file.

The IRIs for eip712 and types are the same as for the previous eip712Domain and messageSchema. I think that is correct, since the objects are intended to have the same purpose/meaning.

Note that the IRIs used here do not link to valid anchors in the specification document; but the document could be updated to make these links work in a browser.

awoie commented 2 years ago

Merging this PR, two approvals.