search

w3c-ccg / http-signatures-test-suite

The HTTP Signatures test suite
Other
8 stars 3 forks source link

Initial #7

Closed aljones15 closed 5 years ago

aljones15 commented 5 years ago

This is the revised code from All tests.

I am currently skipping a few tests:

  1. if duplicate parameters the last parameter defined MUST be used.
  2. Awaiting normative statements on how the spec will handle requests with both Authorization and Signature headers.
liamdennehy commented 5 years ago

the spec for HTTP Messages does think " " is a valid value for an HTTP Header

That's not my reading of Field Parsing. The value is what is left after all leading- and trailing-whitespace characters are removed. Since multiple OWS characters can exist between the colon and field value, two SP characters after the colon are treated as a single delimiter, and the value ends up as a zero-length string.

liamdennehy commented 5 years ago

Please see #11: Use consistent naming of the specification and highlight this suite aims at v11.

Note I did not do a thorough review of content, so likely there are other inconsistencies I have not seen but at least README and reports (that I could find) are correct.

liamdennehy commented 5 years ago

Please review PR #14 for further improvements to this branch, especially README with more details on how the generator is expected to operate in each mode.

Note this only targets as-is, not extensions/fixes such as #8, #9 or #12. I can provide README updates compliant with the decisions in those issues as needed.

aljones15 commented 5 years ago

@liamdennehy there are a few false negatives still in this release, but I went ahead and took this and will issue fixes later.