search

w3c-ccg / lds-ed25519-2018

Linked Data Cryptographic Suite for Ed25519 2018
https://w3c-ccg.github.io/lds-ed25519-2018/
Other
3 stars 4 forks source link

Remove Key in the name #2

Closed mikelodder7 closed 6 years ago

mikelodder7 commented 6 years ago

In some places you have Ed25519VerificationKey. Can we change it to be Ed25519SignatureVerification?

The context is already in a publicKey section so I feel "Key" is redundant.

msporny commented 6 years ago

The context is already in a publicKey section so I feel "Key" is redundant.

I think this is a graph model confusion. "Ed25519SignatureVerificationKey"s are not always contained in "publicKey" properties. In some cases, you just get a raw array of objects back (for example, when you'd do something like a MongoDB database query), and in that case, "publicKey" doesn't exist to give you context. So, in that case, it's not redundant.

peacekeeper commented 6 years ago

Ed25519SigningKey was changed to Ed25519SignatureVerificationKey2018, fixed by 5505eba04df651bf061d51d816609d8fc2dff2bc