Do we need to be more specific about using did document `service` array?

w3c-ccg / traceability-interop

Verifiable Credentials for Supply Chain Interoperability Specification for HTTP

https://w3id.org/traceability/interoperability

Other

28 stars 10 forks source link

Do we need to be more specific about using did document `service` array? #193

Closed brownoxford closed 2 years ago

brownoxford commented 2 years ago

Our tests are now using DID document service array to get base url for presentation verifier (see #182, #183, #191).

We are blindly using services[0].serviceEndpoint for this purpose - should we not instead filter that list for a service with DID URL having #traceability-api fragment or type:"TraceabilityAPI"?

mkhraisha commented 2 years ago

type:"TraceabilityAPI" resonates quite a bit, I think we should be selecting for it

OR13 commented 2 years ago

Also fix the todo noted on https://github.com/w3c-ccg/traceability-interop/pull/191#issuecomment-1095234699

brownoxford commented 2 years ago

I think we can close this now that PRs have been merged.