search

w3c-ccg / traceability-vocab

A traceability vocabulary for describing relevant Verifiable Credentials and their contents.
https://w3id.org/traceability
Other
35 stars 35 forks source link

Don't invent new DateTime types #213

Closed OR13 closed 2 years ago

OR13 commented 2 years ago

originally from https://github.com/w3c-ccg/traceability-vocab/pull/210/files#r736753663

all instances of:

\"@type\": \"https://w3id.org/traceability#DateTime\"

should be like https://github.com/w3c/vc-data-model/blob/main/contexts/credentials/v1#L44:

\"@type\": \"http://www.w3.org/2001/XMLSchema#dateTime\"
rhofvendahl commented 2 years ago

Addressed in https://github.com/w3c-ccg/traceability-vocab/pull/228

cc: @OR13

VladimirAlexiev commented 2 years ago

@OR13 @rhofvendahl You still have 2 occurrences of schema.org/date in IATAAirWaybillCertificate.yml.

You must not use schema datatypes, but should use XSD datatypes: https://github.com/schemaorg/schemaorg/issues/1781, https://github.com/schemaorg/schemaorg/issues/1748

OR13 commented 2 years ago

cc @nissimsan

nissimsan commented 2 years ago

Excellent input - many thanks @VladimirAlexiev. On it...!

OR13 commented 2 years ago

We did it.