conflation of `value` - Githubissues

w3c-ccg / traceability-vocab

A traceability vocabulary for describing relevant Verifiable Credentials and their contents.

https://w3id.org/traceability

Other

34 stars 35 forks source link

conflation of `value` #575

Closed VladimirAlexiev closed 4 months ago

VladimirAlexiev commented 1 year ago

Similar to #571, some schemas map several terms to schema:value, which makes it impossible to distinguish these values in RDF. Eg OFBillOfLading:

  valuePerItem:
    title: Value Per Item
    description: Value Per Item
    type: string
    $linkedData:
      term: valuePerItem
      '@id': https://www.schema.org/value
  totalOrderValue:
    title: Total Order Value
    description: Total value of the order
    type: string
    $linkedData:
      term: totalOrderValue
      '@id': https://www.schema.org/value

then in the example:

    "valuePerItem": "500",
    "totalOrderValue": "1500",

This means that in RDF you cannot tell which number is which.

### Tasks
- [ ] @rhofvendahl creates an issue with checklist for aggriculture
- [ ] Ben and Nis create an issue with checklist for steel

brownoxford commented 1 year ago

Discussed on call, @VladimirAlexiev do you have a specific suggestion on what the values should be here?

nissimsan commented 1 year ago

Good catch. This becomes

    "https://www.schema.org/value": "500",
    "https://www.schema.org/value": "1500",

Not good!

nissimsan commented 1 year ago

Assigning @vivienfan , as this is your guys' schema.

vivienfan commented 1 year ago

@vivienfan

VladimirAlexiev commented 1 year ago

hi @vivienfan and @nissimsan and @brownoxford , You need to analyze the relevant Schema terms: Order, Offer, items, PriceSpecification (for more detailed modeling of prices, including subclasses CompoundPriceSpecification, DeliveryChargeSpecification, PaymentChargeSpecification, UnitPriceSpecification).

All of these use props price (numeric) and priceCurrency (ISO code): they don't use value
Order doesn't have any price fields but has acceptedOffer -> Offer, which itself has price fields. It means you must represent an order either using 2 nodes Order, Offer, or one node with these 2 types and a self-link acceptedOffer
Map totalOrderValue to Offer.price
How do you attach items to the order?
- If you have individual items, link them with itemOffered and map valuePerItem to item.price
- Otherwise map valuePerItem to Offer.priceSpecification[type=UnitPrice.price
Do you allow heterogeneous items in an order, and item multiples?

BenjaminMoe commented 10 months ago

@rhofvendahl to fix these in Agriculture schemas. @nissimsan and @BenjaminMoe to look at steel schemas.

mkhraisha commented 6 months ago

Agriculture was closed with #895 Russel will be tackling steel as a solution to this issue.

nissimsan commented 4 months ago

The last should be fixed now with pr 950, closing