search

w3c-ccg / traceability-vocab

A traceability vocabulary for describing relevant Verifiable Credentials and their contents.
https://w3id.org/traceability
Other
34 stars 35 forks source link

Move sizeOrAmount to AgProduct #941

Closed rhofvendahl closed 6 months ago

rhofvendahl commented 6 months ago

This problem addresses the concern raised in https://github.com/w3c-ccg/traceability-vocab/issues/564 about the sizeOrAmount property on Product. As this is used in ag schemas to indicate unit quantity, I've made a similar unitQuantity property on AgProduct to take its place for ag schemas.

In https://github.com/w3c-ccg/traceability-vocab/issues/564 @mkhraisha said he might like to add volumes on OilAndGasProduct, which seems like a reasonable approach but beyond the scope of this PR.

mkhraisha commented 6 months ago

Lets make sure not to close the issue until the Volume PR is merged as well.

nissimsan commented 6 months ago

@rhofvendahl , please address merge conflict and merge out of band.