Closed VladimirAlexiev closed 7 months ago
Please raise a PR.
@OR13 , @mkhraisha Before anyone can make a PR, there must be agreement how to represent measurements
xsd:decimal
or xsd:double
?value, unit
?
s:value, s:unitCode
I think our final resolution is to use this layout: https://github.com/w3c-ccg/traceability-vocab/issues/532#issuecomment-1589583220
i.e we should use xsd:decimal
and we should use QuantitativeValue
@mkhraisha @BenjaminMoe @OR13 @nissimsan Related to #532, these lines
https://github.com/w3c-ccg/traceability-vocab/blob/8b5efda873a477f9f2e2b906c5099fb65363b58a/docs/openapi/components/schemas/common/CargoItem.yml#L52-L61
https://github.com/w3c-ccg/traceability-vocab/blob/8b5efda873a477f9f2e2b906c5099fb65363b58a/docs/openapi/components/schemas/common/CargoItem.yml#L69-L77
have the following problems:
weightUnit, volumeUnit
as separate props at theCargoItem
level contradicts the discussion/decision in #532 to useMeasuredValue
orQuantitativeValue
: the unit should be inside such nodesvolume
says "Calculated by multiplying the width, height, and length" but there are no fieldsheight, length
volume
is mapped to https://vocabulary.uncefact.org/grossVolumeMeasure but that's a structured node with type https://vocabulary.uncefact.org/MeasureType with fieldsMeasureTypeCode
(unit),MeasureTypeValue
(value) wheres the examples showvolume
to be a decimal.