w3c-ccg / traceability-vocab

A traceability vocabulary for describing relevant Verifiable Credentials and their contents.
https://w3id.org/traceability
Other
34 stars 35 forks source link

bad representation of `weight, volume` in `CargoItem` #943

Closed VladimirAlexiev closed 7 months ago

VladimirAlexiev commented 8 months ago

@mkhraisha @BenjaminMoe @OR13 @nissimsan Related to #532, these lines

https://github.com/w3c-ccg/traceability-vocab/blob/8b5efda873a477f9f2e2b906c5099fb65363b58a/docs/openapi/components/schemas/common/CargoItem.yml#L52-L61

https://github.com/w3c-ccg/traceability-vocab/blob/8b5efda873a477f9f2e2b906c5099fb65363b58a/docs/openapi/components/schemas/common/CargoItem.yml#L69-L77

have the following problems:

OR13 commented 8 months ago

Please raise a PR.

VladimirAlexiev commented 8 months ago

@OR13 , @mkhraisha Before anyone can make a PR, there must be agreement how to represent measurements

nissimsan commented 7 months ago

Decision here: https://github.com/w3c-ccg/traceability-vocab/issues/532#issuecomment-1589583220

mkhraisha commented 7 months ago

I think our final resolution is to use this layout: https://github.com/w3c-ccg/traceability-vocab/issues/532#issuecomment-1589583220

i.e we should use xsd:decimal and we should use QuantitativeValue