search

w3c-ccg / universal-wallet-interop-spec

A data model and abstract interfaces for digital wallets
http://w3id.org/wallet
Other
56 stars 13 forks source link

Feature/naming cleanup #44

Closed mprorock closed 3 years ago

mprorock commented 3 years ago

fixes issues related to issues:

OR13 commented 3 years ago

https://www.npmjs.com/package/@w3c-ccg <- this namespace does not exist (yet), would need to have it be created and setup to accept this PR.

... also a question for the CCG Chairs, since this is probably more of their wheel house.

@w3c-ccg/chairs

I am happy to help set this up, but it would make the CCG responsible for software packages / security updates / npm tokens, etc...

mprorock commented 3 years ago

holding on this for another day or so while we wait for chair input. will make adjustments as request by @OR13 to account for lerna

OR13 commented 3 years ago

@mprorock I will close this PR in 1 week, if the code changes are not reverted :)

Suggest we split this up into phases... also regarding npm namespaces, there is nothing stopping you from doing @mesur/universal-wallet-did-web-plugin and committing the source to this repo as I have done for transmute, while we wait for guidance from the CCG....

Alternatively, as an owner the @transmute/universal-wallet-edv-plugin I can give you / this repo publish token for the npm module and setup CI/CD with or without the chair input (they can't see tokens)... we do something similar here: https://material-did.com/?path=/story/*

probably CI/CD with automatic builds will make all downstream consumers happy and the NPM namespace is mostly irrelevant to setting that up.

mprorock commented 3 years ago

@mprorock I will close this PR in 1 week, if the code changes are not reverted :)

Suggest we split this up into phases... also regarding npm namespaces, there is nothing stopping you from doing @mesur/universal-wallet-did-web-plugin and committing the source to this repo as I have done for transmute, while we wait for guidance from the CCG....

Agreed - will go through and break this up towards the end of the week

wyc commented 3 years ago

Thanks for the interest and suggested of a CCG npm package repo, please see here for an update: https://github.com/w3c-ccg/vc-http-api/issues/79#issuecomment-737597078

mprorock commented 3 years ago

updated with remove of @w3c-ccg namespacing for now while we sort that out @OR13