search

w3c-ccg / universal-wallet-interop-spec

A data model and abstract interfaces for digital wallets
http://w3id.org/wallet
Other
56 stars 13 forks source link

Move non ui npm module to mono repo #71

Closed OR13 closed 3 years ago

OR13 commented 3 years ago

Moving the non ui wallet related code out of this repo.

Hoping to add more examples, using aries framework go, and other wallet libs and keep this repo focused on spec and ui and not wallet implementation details.

OR13 commented 3 years ago

@kimdhamilton all the npm modules in the repo are currently under @transmute, and the latest versions of them are now hosted here: https://github.com/transmute-industries/linked-data/tree/main/packages/universal-wallet

Its difficult to manage our wallet implementation @transmute/universal-wallet in the ccg, and we also don't want to diminish the work @sudeshrshetty and others are doing on implementing the spec and its interfaces.

This PR just moves npm package code under our github organization (we already controlled the packages before).

This module: https://github.com/w3c-ccg/universal-wallet-interop-spec/tree/master/packages/universal-wallet-react

hosts the react and material ui components associated with the spec.

technically its also name-spaced under transmute: https://github.com/w3c-ccg/universal-wallet-interop-spec/blob/master/packages/universal-wallet-react/package.json#L2

I'm not opposed to ccg maintainers forking any of this work or continuing to maintain forks and npm modules in the ccg, but things like CI/CD deployment and integrations with our other software are harder for us for packages under @transmute namespace when hosted in the ccg.

End of the day, as a small company we want to be able to move a little faster, and align out wallet implementation of the ccg spec with our other software tooling, etc.

If anyone is interested in maintaining independent implementations of these modules, I fully support them dropping / swapping out @transmute in the package json, and hosting their version in the ccg or elsewhere.

the important thing is that the interfaces and data model in the spec have independent interoperable implementations.

In our case, we want to be able to wire our wallet implementation to other test suites, like our vc http api and other tooling, as SecureKey and Spruce have recently done.

I expect if this spec is successful we will eventually have wallet interop tests that span multiple implementations similar to the vc http api tests and the did core tests.

kimdhamilton commented 3 years ago

Don't get me wrong, this codebase needs to be refactored (perhaps split into 2 CCG repos), but this changes the scope of this work item.

As a code owner I reject this change.

OR13 commented 3 years ago

I'm gonna close this and we will open another pr that fixes the npm publishing issue and removes the @transmute namespace